Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving from string version to FourPartVersion #128

Open
arthuraraujo-msft opened this issue Mar 8, 2024 · 0 comments
Open

Consider moving from string version to FourPartVersion #128

arthuraraujo-msft opened this issue Mar 8, 2024 · 0 comments
Labels
nice to have This is not required, but would be nice to have
Milestone
Future

Comments

@arthuraraujo-msft
Copy link
Contributor 

          L20: Consider moving from `string version` to FourPartVersion

https://github.com/JeffMill/AzureContentDelivery.Client/blob/main/src/UtilityLib/include/FourPartVersion.h

https://github.com/JeffMill/AzureContentDelivery.Client/blob/main/src/UtilityLib/src/FourPartVersion.cpp

(it uses Boost, but that should be easy to adapt)

Aside from me being proud of my implementation :-), it really came in handy as it does validation, comparisons, streams (e.g. cout << version << endl), etc.

Originally posted by @JeffMill in #117 (comment)
@arthuraraujo-msft arthuraraujo-msft mentioned this issue Mar 8, 2024
Merged
@arthuraraujo-msft arthuraraujo-msft added the nice to have This is not required, but would be nice to have label Mar 8, 2024
@arthuraraujo-msft arthuraraujo-msft added this to the Future milestone Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice to have This is not required, but would be nice to have
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@arthuraraujo-msft