Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions should register problem matchers for errors and warnings #4

Open
chrispat opened this issue Mar 10, 2020 · 5 comments
Open
Assignees
Labels
help wanted Extra attention is needed

Comments

@chrispat
Copy link

Please see the actions/setup-dotnet repo as an example.

https://github.com/actions/setup-dotnet/blob/master/src/setup-dotnet.ts#L30
https://github.com/actions/setup-dotnet/blob/master/.github/csc.json

@timheuer
Copy link
Member

@chrispat is there more documentation on what this is, where it surfaces, why it is important?

@timheuer timheuer self-assigned this Mar 26, 2020
@chrispat
Copy link
Author

The problem matcher will automatically surface as annotations on the pull request and other files so you could easily see where compiler errors or warnings are. The design is essentially the same as VSCode which uses them to give you errors and warnings in the editor rather than having to dig through the text log.

@timheuer
Copy link
Member

Are there docs on this. I see the repo you pointed to but not sure if I directly copy that or how can I learn more about the json files and relationships. Totally up to do this. Guide me?

@chrispat
Copy link
Author

@timheuer timheuer added the help wanted Extra attention is needed label Aug 24, 2021
@reupen
Copy link

reupen commented Feb 17, 2022

I tried using a problem matcher in one of my repos, but I abandoned it as it didn't handle message for a single error or warning that spanned multiple lines, and was also generally a pain for various reasons.

I'm now using a custom logger which is a much more flexible solution. I've published the one I created here:
https://github.com/reupen/msbuild-github-logger

I've also dumped the abandoned problem matcher here in case it's of use to anyone (it is possible to register a problem matcher from your own workflow for reference):

https://gist.github.com/reupen/f2320e353554f4fa4d3693fd38c850d4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants