Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneeded dependency on @actions/tool-cache #135

Open
PhilipAtCisco opened this issue Nov 19, 2024 · 1 comment
Open

Unneeded dependency on @actions/tool-cache #135

PhilipAtCisco opened this issue Nov 19, 2024 · 1 comment
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@PhilipAtCisco
Copy link

Looks like this code once directly depended on @actions/tool-cache but no longer does.

This dependency could be removed from package.json which clears this transitive semver vulnerability CVE-2022-25883
"@actions/tool-cache": "^1.3.0"

~/src/setup-msbuild/src$ git grep tool-cache $(git rev-list --all)
3ef0817a4abf99a3632a7c77a60e982a156db578:main.ts:import * as toolCache from '@actions/tool-cache'
5817abf347fd91d634f86da6635e14e39a3b1b66:main.ts:import * as toolCache from '@actions/tool-cache'
dd9521cc411535ba013905b144116257817da37b:main.ts:import * as toolCache from '@actions/tool-cache'
5a941602d277d18f27537d169fc01b7696c3e095:main.ts:import * as toolCache from '@actions/tool-cache'
6a7105d96d081fdf3bdb20ec966186aa56cd9a82:main.ts:import * as toolCache from '@actions/tool-cache'
5639ea3d911c64ff68d708ddd6aa66c905716e67:main.ts:import * as toolCache from '@actions/tool-cache'
ded5a39da68208ac982f80008c4e9f72f77229f7:main.ts:import * as toolCache from '@actions/tool-cache'
~/src/setup-msbuild/src$ grep tool-cache main.ts
~/src/setup-msbuild/src$
@timheuer timheuer self-assigned this Nov 19, 2024
@timheuer
Copy link
Member

Thanks @PhilipAtCisco will take a look.

@timheuer timheuer added the dependencies Pull requests that update a dependency file label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants