Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Agents - Review Logging Levels / Practices #6095

Closed
crickman opened this issue May 2, 2024 · 2 comments · Fixed by #7069
Closed

.Net: Agents - Review Logging Levels / Practices #6095

crickman opened this issue May 2, 2024 · 2 comments · Fixed by #7069
Assignees
@crickman
Labels
agents experimental Associated with an experimental feature follow up Issues that require a follow up from the community. .NET Issue or Pull requests regarding .NET code

Comments

@crickman
Copy link
Contributor

crickman commented May 2, 2024

Review use of DEBUG / INFORMATION / ERROR

Refer to KernelFunctionLogMessages as possible reference.
@crickman crickman added .NET Issue or Pull requests regarding .NET code follow up Issues that require a follow up from the community. experimental Associated with an experimental feature agents labels May 2, 2024
@crickman crickman self-assigned this May 2, 2024
@github-actions github-actions bot changed the title Agents - Review Logging Levels / Practices .Net: Agents - Review Logging Levels / Practices May 2, 2024
@markwallace-microsoft
Copy link
Member

We should refer to this guidance https://learn.microsoft.com/en-us/dotnet/core/extensions/logging-library-authors

@crickman
Copy link
Contributor Author

crickman commented May 6, 2024

Yes this is all good. I was discussing the LogMessages approach with Dmytro. I think we nailed the other aspects outlined in this article. Was there something specific on your mind to call out?

@crickman crickman linked a pull request Jul 11, 2024 that will close this issue
.Net Agents - Add dynamic logging methods #7069
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crickman crickman

Labels
agents experimental Associated with an experimental feature follow up Issues that require a follow up from the community. .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net Agents - Add dynamic logging methods microsoft/semantic-kernel
3 participants
@matthewbolanos @crickman @markwallace-microsoft