Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Plugin name inside FunctionInvokingContext in th IFunctionFilter is null #5452

Closed
EdenTanami opened this issue Mar 12, 2024 · 3 comments
Assignees
Labels
core plugin Anything related to core plugins .NET Issue or Pull requests regarding .NET code

Comments

@EdenTanami
Copy link

Describe the bug
In the function filter we receive the FunctionInvokingContext object and inside it the kernelFunction but for some reason the pluginName attribute inside the function metadata is null
(the kernelFunction that is registered in the kernel has valid pluginName).

To Reproduce
Steps to reproduce the behavior:

  1. Write any function filter and register to the kernel.
  2. Inside OnFunctionInvoking or OnFunctionInvoked the following value is null:
    context.Function.Metadata.PluginName

Expected behavior
The plugin name will have the same value it has in the kernelFunction that is register in the kernel.

Screenshots
image

image

Platform

  • OS: Windows
  • IDE: Visual Studio,
  • Language: C#
  • Source: SK NuGet package version 1.5.0
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels Mar 12, 2024
@github-actions github-actions bot changed the title Plugin name inside FunctionInvokingContext in th IFunctionFilter is null .Net: Plugin name inside FunctionInvokingContext in th IFunctionFilter is null Mar 12, 2024
@dmytrostruk
Copy link
Member

I think this issue should be fixed by this PR: #5422.
@markwallace-microsoft please confirm.

@evchaki evchaki added the core plugin Anything related to core plugins label Mar 12, 2024
@Krzysztof318
Copy link
Contributor

Krzysztof318 commented Mar 12, 2024

@dmytrostruk and this one #5171 :)

@markwallace-microsoft
Copy link
Member

This issue is being handled by #4706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core plugin Anything related to core plugins .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

No branches or pull requests

5 participants