Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush] Add support for PNPM's --strict-peer-dependencies feature #817

Merged
merged 5 commits into from
Sep 7, 2018
Merged

[rush] Add support for PNPM's --strict-peer-dependencies feature #817

merged 5 commits into from
Sep 7, 2018

Conversation

octogonz
Copy link
Collaborator

@octogonz octogonz commented Sep 7, 2018 •
edited
Loading

We recently got broken again by unsatisfied peer dependencies. PNPM prints a warning, but everyone ignored this warning because it was buried under a bunch of other warnings.

The GitHub issue pnpm/pnpm#1142 was resolved in PNPM 2.15.0. This PR adds a Rush configuration option to enable this feature.

To enable this validation in your repo, add this to your rush.json file:

  "pnpmOptions": {
    "strictPeerDependencies": true
  },

iclanton
iclanton reviewed Sep 7, 2018
View reviewed changes
Copy link
Member

@iclanton iclanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

nickpape
nickpape reviewed Sep 7, 2018
View reviewed changes
common/reviews/api/rush-lib.api.ts
// @public
class PnpmOptionsConfiguration {
// WARNING: The type "IPnpmOptionsJson" needs to be exported by the package (e.g. added to index.ts)
// @internal
Copy link
Contributor

@nickpape nickpape Sep 7, 2018 •
edited by octogonz
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal [](start = 6, length = 8)

@Private ? #WontFix

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. But this is an API Extractor feature request that's out of scope for this PR.

In reply to: 216065927 [](ancestors = 216065927)

nickpape
nickpape approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@nickpape nickpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@octogonz octogonz changed the title Add support for PNPM's --strict-peer-dependencies feature [rush] Add support for PNPM's --strict-peer-dependencies feature Sep 7, 2018
@octogonz
Copy link
Collaborator Author

octogonz commented Sep 7, 2018

@patmill FYI

nickpape
nickpape suggested changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@nickpape nickpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@octogonz octogonz force-pushed the pgonzal/pnpm-strict-peers branch from eead140 to fe57944 Compare September 7, 2018 21:58
@octogonz
Copy link
Collaborator Author

octogonz commented Sep 7, 2018 •
edited by iclanton
Loading

:shipit:

Approved with PullApprove Approved with PullApprove

@octogonz octogonz merged commit fa60881 into master Sep 7, 2018
@octogonz octogonz deleted the pgonzal/pnpm-strict-peers branch October 3, 2018 23:37
This was referenced Feb 6, 2019
Closed
Closed
@mikeharder mikeharder mentioned this pull request Jun 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iclanton iclanton iclanton left review comments

@nickpape nickpape nickpape requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@octogonz @iclanton @nickpape @pgonzal