From 924e141604b88fbbc69e15ec0e9835f13be5acb9 Mon Sep 17 00:00:00 2001 From: Ian Clanton-Thuon Date: Fri, 6 Sep 2024 16:00:32 -0700 Subject: [PATCH] Expose AzureAuthenticationBase._credentialCacheId. --- .../expose_credentialCacheId_2024-09-06-23-00.json | 10 ++++++++++ .../api/rush-azure-storage-build-cache-plugin.api.md | 2 ++ .../src/AzureAuthenticationBase.ts | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 common/changes/@microsoft/rush/expose_credentialCacheId_2024-09-06-23-00.json diff --git a/common/changes/@microsoft/rush/expose_credentialCacheId_2024-09-06-23-00.json b/common/changes/@microsoft/rush/expose_credentialCacheId_2024-09-06-23-00.json new file mode 100644 index 00000000000..36854f71aa8 --- /dev/null +++ b/common/changes/@microsoft/rush/expose_credentialCacheId_2024-09-06-23-00.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@microsoft/rush", + "comment": "Mark `AzureAuthenticationBase._credentialCacheId` as protected in `@rushstack/rush-azure-storage-build-cache-plugin`.", + "type": "none" + } + ], + "packageName": "@microsoft/rush" +} \ No newline at end of file diff --git a/common/reviews/api/rush-azure-storage-build-cache-plugin.api.md b/common/reviews/api/rush-azure-storage-build-cache-plugin.api.md index 9c5d5f4aee4..4e56fc2bb0b 100644 --- a/common/reviews/api/rush-azure-storage-build-cache-plugin.api.md +++ b/common/reviews/api/rush-azure-storage-build-cache-plugin.api.md @@ -24,6 +24,8 @@ export abstract class AzureAuthenticationBase { // (undocumented) protected readonly _azureEnvironment: AzureEnvironmentName; // (undocumented) + protected get _credentialCacheId(): string; + // (undocumented) protected abstract readonly _credentialKindForLogging: string; // (undocumented) protected abstract readonly _credentialNameForCache: string; diff --git a/rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureAuthenticationBase.ts b/rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureAuthenticationBase.ts index aa3eb2c254b..99c39ae58a6 100644 --- a/rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureAuthenticationBase.ts +++ b/rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureAuthenticationBase.ts @@ -131,7 +131,7 @@ export abstract class AzureAuthenticationBase { protected readonly _failoverOrder: Record; private __credentialCacheId: string | undefined; - private get _credentialCacheId(): string { + protected get _credentialCacheId(): string { if (!this.__credentialCacheId) { const cacheIdParts: string[] = [ this._credentialNameForCache,