Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Add support for string parameter in custom commands #1190

Merged
merged 5 commits into from
Mar 29, 2019

Conversation

dotnetjunky
Copy link
Contributor

This is to address issue #1189 : Allows custom commands to specify parameters of string types, in addition to flag and choice.

@dotnetjunky
Copy link
Contributor Author

@acoates-ms Check this out.

@octogonz octogonz merged commit ecb9676 into microsoft:master Mar 29, 2019
@dotnetjunky dotnetjunky deleted the kinhln/string-param branch March 29, 2019 03:47
@chrisdothtml
Copy link

Has this change been released? I don't see it in the documentation or schema

@chrisdothtml
Copy link

@dotnetjunky @octogonz anything? Would like to use this feature but don't know how. Thanks!

@octogonz
Copy link
Collaborator

@chrisdothtml Sorry I missed your comment. This feature was published with Rush 5.6.4; in order to use it, you would need to update rushVersion in your rush.json file.

I see it in the current JSON schema.

It does appear to be missing from the docs. If you want to open a GitHub issue for the web site, we can get the docs updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants