Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Regression: folderToCopy creates subfolder in deploy folder #4444

Closed
nlochschmidt opened this issue Dec 6, 2023 · 2 comments · Fixed by #4451
Closed

[rush] Regression: folderToCopy creates subfolder in deploy folder #4444

nlochschmidt opened this issue Dec 6, 2023 · 2 comments · Fixed by #4451

Comments

@nlochschmidt
Copy link

nlochschmidt commented Dec 6, 2023

Summary

In rush version 5.107.4 the folderToCopy option in deploy.json works as documented and places the files in the referenced folder top-level into common/deploy. From version 5.108.0 onwards however a subfolder gets created in common/deploy.

Repro steps

  1. Create a deploy.json with a folderToCopy pointing to a folder with some files
  2. Run rush deploy --overwrite in version 5.107.4 and check common/deploy to see the files top-level
  3. Switch to any version from 5.108.0 to 5.112.1
  4. Run rush deploy --overwrite again and check common/deploy to see the files now inside of a folder with the name of the source folder

Standard questions

Question Answer
@microsoft/rush globally installed version? 5.112.1
rushVersion from rush.json? 5.112.1
useWorkspaces from rush.json? true
Operating system? Mac
Would you consider contributing a PR? Yes
Node.js version (node -v)? 18.18.4
@nlochschmidt
Copy link
Author

Possibly related to #4373

@github-project-automation github-project-automation bot moved this to Needs triage in Bug Triage Dec 11, 2023
@iclanton iclanton moved this from Needs triage to Needs Investigation in Bug Triage Dec 11, 2023
@github-project-automation github-project-automation bot moved this from Needs Investigation to Closed in Bug Triage Dec 11, 2023
@iclanton
Copy link
Member

Fixed in Rush 5.112.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants