Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Inconsistent yaml serialization during rush update #2602

Closed
dmichon-msft opened this issue Apr 9, 2021 · 0 comments · Fixed by #2610
Closed

[rush] Inconsistent yaml serialization during rush update #2602

dmichon-msft opened this issue Apr 9, 2021 · 0 comments · Fixed by #2610

Comments

@dmichon-msft
Copy link
Contributor

dmichon-msft commented Apr 9, 2021

Summary

Depending on if the lockfile gets modified by the package manager or not, the version of pnpm-lock.yaml that gets copied back to common/config/rush/pnpm-lock.yaml will have or not have quotes around link: fields.

Repro steps

  1. Enable usePnpmPreferFrozenLockfileForRushUpdate
  2. Make an unnecessary invocation of rush update. Pnpm will see that the lockfile is up-to-date and not modify it, but rush will copy back the version it emitted.

Solution is to have rush always read and reserialize pnpm-lock.yaml when writing back to common/config/rush/pnpm-lock.yaml instead of copying.

Details

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version? 5.42.4
rushVersion from rush.json? 5.42.4
useWorkspaces from rush.json? true
Operating system? Windows
Would you consider contributing a PR? Yes
Node.js version (node -v)? 12.22.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant