Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] allow to specify command directly in command-line.json #1797

Open
slavafomin opened this issue Mar 27, 2020 · 1 comment · May be fixed by #4236
Open

[rush] allow to specify command directly in command-line.json #1797

slavafomin opened this issue Mar 27, 2020 · 1 comment · May be fixed by #4236
Assignees
Labels
effort: easy Probably a quick fix. Want to contribute? :-) enhancement The issue is asking for a new feature or design change help wanted If you're looking to contribute, this issue is a good place to start!

Comments

@slavafomin
Copy link

It should be possible to specify default command in command-line.json file directly and to override it in individual packages (if needed).

Just forking discussion from this thread: #1168 (comment)

The approach where you need to specify the actual command in each and every package is terrible when it's the same for all packages. This breaks DRY principle and creates a lot of overhead where you need to first add the script to each package and then to update it when the need arise.

I would suggest to:

1). Allow to specify the default implementation of the command directly in command-line.json

2). Allow to override this command in packages when you need to.

The logic is simple: if the script is defined in the package in question — run it, otherwise run the default command.

@Claudiazhaoya Claudiazhaoya self-assigned this Apr 2, 2020
@octogonz octogonz added the enhancement The issue is asking for a new feature or design change label Apr 8, 2020
@octogonz
Copy link
Collaborator

octogonz commented Apr 8, 2020

This is a good idea. It should be relatively easy to implement.

@iclanton iclanton added effort: easy Probably a quick fix. Want to contribute? :-) help wanted If you're looking to contribute, this issue is a good place to start! labels Apr 20, 2020
@iclanton iclanton moved this to Low priority in Bug Triage Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: easy Probably a quick fix. Want to contribute? :-) enhancement The issue is asking for a new feature or design change help wanted If you're looking to contribute, this issue is a good place to start!
Projects
Status: Low priority
Development

Successfully merging a pull request may close this issue.

4 participants