Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush] Simplify setting allowWarningsInSuccessfulBuild for build and rebuild commands #1375

Closed
mikeharder opened this issue Jul 11, 2019 · 1 comment · Fixed by #1485
Closed

[rush] Simplify setting allowWarningsInSuccessfulBuild for build and rebuild commands #1375

mikeharder opened this issue Jul 11, 2019 · 1 comment · Fixed by #1485
Labels
effort: easy Probably a quick fix. Want to contribute? :-) enhancement The issue is asking for a new feature or design change help wanted If you're looking to contribute, this issue is a good place to start!

Comments

@mikeharder
Copy link
Contributor

Please add a simpler method to set allowWarningsInSuccessfulBuild for the build and rebuild commands, without duplicating the commands in command-line.json. More details:

#1329 (comment)
@mikeharder mikeharder changed the title Simplify setting allowWarningsInSuccessfulBuild for "build" and "rebuild" commands Simplify setting allowWarningsInSuccessfulBuild for build and rebuild commands Jul 11, 2019
@iclanton iclanton changed the title Simplify setting allowWarningsInSuccessfulBuild for build and rebuild commands [rush] Simplify setting allowWarningsInSuccessfulBuild for build and rebuild commands Jul 12, 2019
@rakeshpatnaik rakeshpatnaik added effort: easy Probably a quick fix. Want to contribute? :-) help wanted If you're looking to contribute, this issue is a good place to start! labels Jul 12, 2019
@octogonz
Copy link
Collaborator

When build or rebuild is specified command-line.json, any omitted settings should default to the build-in settings as defined by _addDefaultBuildActions(). Since we're just merging settings from two objects, this should be pretty easy to implement.

@octogonz octogonz added the enhancement The issue is asking for a new feature or design change label Jul 21, 2019
@darsi-an darsi-an mentioned this issue Aug 24, 2019
Merged
@boardend boardend mentioned this issue Oct 9, 2019
Open
@iclanton iclanton moved this to Closed in Bug Triage Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: easy Probably a quick fix. Want to contribute? :-) enhancement The issue is asking for a new feature or design change help wanted If you're looking to contribute, this issue is a good place to start!
Projects
Bug Triage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rush] Add support to simplify setting for build and rebuild commands darsi-an/web-build-tools
3 participants
@octogonz @mikeharder @rakeshpatnaik