Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush] Using pnpm & webpack, some modules are unexpectedly included multiple times #1219

Closed
elliottsj opened this issue Apr 9, 2019 · 2 comments
Closed

[rush] Using pnpm & webpack, some modules are unexpectedly included multiple times #1219

elliottsj opened this issue Apr 9, 2019 · 2 comments
Labels
repro confirmed The issue comments included repro instructions, and the maintainers reproduced the problem

Comments

@elliottsj
Copy link
Contributor

Full description in https://github.com/elliottsj/rush-pnpm-webpack-duplicate-module-issue

Like #1142, this seems to happen when using Rush + pnpm, but does not occur when using just pnpm.

I'm hoping this will be resolved by #1180
@octogonz octogonz added the repro confirmed The issue comments included repro instructions, and the maintainers reproduced the problem label Apr 9, 2019
@octogonz
Copy link
Collaborator

octogonz commented Apr 9, 2019 •
edited
Loading

@iclanton do you have time to review PR #1210?

@HarryGifford HarryGifford mentioned this issue May 15, 2019
Closed
@octogonz
Copy link
Collaborator

Closing this because it should be solved by the new resolutionStrategy=fewer-dependencies setting in rush.json. That feature was introduced by Rush 5.7.x and is enabled by default.

Please reopen this issue if it did not solve your problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repro confirmed The issue comments included repro instructions, and the maintainers reproduced the problem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elliottsj @octogonz