-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] Add support for PNPM Version 3 #1145
Comments
Damn... the config file names have changed:
Rush uses the term "shrinkwrap" generically for all package managers. I guess we'll need to update that, too. @iclanton FYI |
The PNPM filename is in RushConstants.ts. Rush has been using the term "shrinkwrap file" to refer generically to this file across NPM/Yarn/PNPM. This was the name originally used by NPM, but if all the package managers are now calling it a "lock file", we should update our terminology. (This term "lock file" has a different, widely established meaning in the software industry that predates Ruby GEM and even the JavaScript language. Maybe Rush should call it something like "version lock file" or "package lock file" to avoid ambiguity.) This fix should not break support for PNPM 2.x, so it seems like we need to select the filename based on pnpmVersion. |
In a gitter thread @poelstra suggested that Rush should print an error if the package manager didn't create the filename that it was expected to create. Without that, he had a really confusing experience where he tried the "latest" version of PNPM and it mysteriously succeeded but there wasn't any shrinkwrap file. |
I just had a similar "really confusing experience" where We're considering to switch from lerna+yarn to rush+pnpm in our monorepo and I'm following https://rushjs.io/pages/maintainer/setup_new_repo/ which tells me to "check that you’re using recent stable releases for any other applicable fields such as A pointer from the documentation to this issue would have been appreciated. Or maybe https://rushjs.io/pages/maintainer/package_managers/ could mention the most recent pnpm version that is "known to work". |
Is this completed by #1210? |
Yup |
As title says, there are a few breaking changes for this release.
https://github.com/pnpm/pnpm/releases
The text was updated successfully, but these errors were encountered: