-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watermark plugin's text value can't be updated or localized #2430
Comments
Thanks for reporting. Yes, it is the current behavior. I think Watermark plugin can provide a callback function in its ctor to allow you provide a latest text. Do you want to make a fix as a self service? |
It would be great if RoosterJS team has capasity to add this functionality. |
Can you try this PR #2503 |
Unfortunately, it won't work for me as I use the current RoosterJS version (not content model one). But I'll share a PR soon with the changes for it. |
#2507 is merged with updated Watermark plugin functionality |
Describe the bug
It looks like there is no way to update the Watermark's plugin text value after the Watermark plugin is added to an Editor. This causes issues when watermark needs to be localized later after the component is shown. Please see steps to reproduce for the RoosterJS Demo Site when watermark is updated
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The watermark text can be updated or at least localized.
Screenshots
Screen.Recording.2024-02-20.at.11.15.35.AM.mov
Device Information
The text was updated successfully, but these errors were encountered: