Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnableMultipleHttp2Connections not covered in samples/docs #2323

Closed
Tratcher opened this issue Nov 13, 2023 · 1 comment · Fixed by #2451
Closed

EnableMultipleHttp2Connections not covered in samples/docs #2323

Tratcher opened this issue Nov 13, 2023 · 1 comment · Fixed by #2451
Labels
Type: Documentation Improvements or additions to documentation

Comments

@Tratcher
Copy link
Member

SocketsHttpHandler.EnableMultipleHttp2Connections is enabled by default by YARP for better performance in server-to-server communication. However, that's not shown in our docs/samples where a SocketsHttpHandler is manually configured. This can cause perf issues for users like #2282.
https://microsoft.github.io/reverse-proxy/articles/http-client-config.html
https://microsoft.github.io/reverse-proxy/articles/direct-forwarding.html

var httpClient = new HttpMessageInvoker(new SocketsHttpHandler()

var httpClient = new HttpMessageInvoker(new SocketsHttpHandler()

@Tratcher Tratcher added Type: Documentation Improvements or additions to documentation help wanted We will welcome a contribution labels Nov 13, 2023
@jakebanks
Copy link
Contributor

Please also update it here, thanks https://microsoft.github.io/reverse-proxy/articles/http-client-config.html#custom-iforwarderhttpclientfactory

@karelz karelz added this to the v.Next milestone Nov 28, 2023
@MihaZupan MihaZupan removed the help wanted We will welcome a contribution label Mar 25, 2024
@MihaZupan MihaZupan modified the milestones: v.Next, YARP 2.2.0-preview1 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants