Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test end-to-end multi-value header support #155

Closed
Tratcher opened this issue May 12, 2020 · 3 comments · Fixed by #1498
Closed

Test end-to-end multi-value header support #155

Tratcher opened this issue May 12, 2020 · 3 comments · Fixed by #1498
Assignees
Labels
Type: Task A task that needs to be completed.

Comments

@Tratcher
Copy link
Member

In theory the HTTP spec allows any multi-value headers to be represented as a single comma separated list or as multiple key: value headers. In practice there are at least two headers that break clients if merged to a single line, Set-Cookie and WWW-Authenticate.

Test the end-to-end experience for multi-value request and response headers, especially Set-Cookie and WWW-Authenticate. A header's format should be maintained as much as possible in either direction. E.g. don't split up a comma separated list into multiple headers, and don't combine multiple headers into a comma separated list.

There are known issues with Http.Sys and IIS data structures combining multi-value request headers.

@Tratcher Tratcher added the Type: Task A task that needs to be completed. label May 12, 2020
@karelz karelz added this to the 1.0.0 milestone May 14, 2020
@Tratcher
Copy link
Member Author

#437 is a good example of how this can break.

@Tratcher
Copy link
Member Author

Another example:
#467 (comment)

@karelz karelz modified the milestones: YARP 1.0.0, Backlog Mar 24, 2021
@samsp-msft samsp-msft added the samsp_list Personal tag used when reviewing issues for further discussion label Dec 9, 2021
@samsp-msft
Copy link
Contributor

Tagging as its the kind of thing that will cause problems for one of our services.

@karelz karelz modified the milestones: Backlog, YARP 1.1.0 Dec 16, 2021
@karelz karelz removed the samsp_list Personal tag used when reviewing issues for further discussion label Dec 16, 2021
@greenEkatherine greenEkatherine linked a pull request Jan 17, 2022 that will close this issue
1 task
@MihaZupan MihaZupan modified the milestones: YARP 1.1.0, YARP 1.1.0-RC1 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Task A task that needs to be completed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants