From 28f7ea7802c07855121b3e3ea77e2cc0e4fb20a1 Mon Sep 17 00:00:00 2001 From: Ilya Matiach Date: Thu, 31 Mar 2022 11:40:31 -0400 Subject: [PATCH] fix codecov comment not appearing on PRs (#1302) --- .github/workflows/CI-python.yml | 7 ++++--- .github/workflows/Ci-raiwigets-python-typescript.yml | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/CI-python.yml b/.github/workflows/CI-python.yml index 6fa88b2951..110df5e2e5 100644 --- a/.github/workflows/CI-python.yml +++ b/.github/workflows/CI-python.yml @@ -74,7 +74,7 @@ jobs: # Use always() to always run this step to publish test results when there are test failures if: ${{ always() }} - - if: ${{ (matrix.operatingSystem == 'ubuntu-latest') && (matrix.pythonVersion == '3.7') }} + - if: ${{ (matrix.operatingSystem == 'windows-latest') && (matrix.pythonVersion == '3.8') }} name: Upload to codecov id: codecovupload1 uses: codecov/codecov-action@v2 @@ -88,7 +88,7 @@ jobs: name: codecov-umbrella verbose: true - - if: ${{ (steps.codecovupload1.outcome == 'failure') && (matrix.pythonVersion == '3.7') && (matrix.operatingSystem == 'ubuntu-latest') }} + - if: ${{ (steps.codecovupload1.outcome == 'failure') && (matrix.pythonVersion == '3.8') && (matrix.operatingSystem == 'windows-latest') }} name: Retry upload to codecov id: codecovupload2 uses: codecov/codecov-action@v2 @@ -103,7 +103,8 @@ jobs: verbose: true - name: Set codecov status - if: ${{ (matrix.pythonVersion == '3.7') && (matrix.operatingSystem == 'ubuntu-latest') }} + if: ${{ (matrix.pythonVersion == '3.8') && (matrix.operatingSystem == 'windows-latest') }} + shell: bash run: | if ${{ (steps.codecovupload1.outcome == 'success') || (steps.codecovupload2.outcome == 'success') }} ; then echo fine diff --git a/.github/workflows/Ci-raiwigets-python-typescript.yml b/.github/workflows/Ci-raiwigets-python-typescript.yml index dc43a5109f..e53cfcf842 100644 --- a/.github/workflows/Ci-raiwigets-python-typescript.yml +++ b/.github/workflows/Ci-raiwigets-python-typescript.yml @@ -106,7 +106,7 @@ jobs: # Use always() to always run this step to publish test results when there are test failures if: ${{ always() }} - - if: ${{ (matrix.operatingSystem == 'ubuntu-latest') && (matrix.pythonVersion == '3.7') }} + - if: ${{ (matrix.operatingSystem == 'windows-latest') && (matrix.pythonVersion == '3.8') }} name: Upload to codecov id: codecovupload1 uses: codecov/codecov-action@v2 @@ -120,7 +120,7 @@ jobs: name: codecov-umbrella verbose: true - - if: ${{ (steps.codecovupload1.outcome == 'failure') && (matrix.pythonVersion == '3.7') && (matrix.operatingSystem == 'ubuntu-latest') }} + - if: ${{ (steps.codecovupload1.outcome == 'failure') && (matrix.pythonVersion == '3.8') && (matrix.operatingSystem == 'windows-latest') }} name: Retry upload to codecov id: codecovupload2 uses: codecov/codecov-action@v2 @@ -142,7 +142,8 @@ jobs: path: dist/cypress - name: Set codecov status - if: ${{ (matrix.pythonVersion == '3.7') && (matrix.operatingSystem == 'ubuntu-latest') }} + if: ${{ (matrix.pythonVersion == '3.8') && (matrix.operatingSystem == 'windows-latest') }} + shell: bash run: | if ${{ (steps.codecovupload1.outcome == 'success') || (steps.codecovupload2.outcome == 'success') }} ; then echo fine