Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigator: Disable animation on popToTop #1027

Closed
blelem opened this issue Feb 18, 2019 · 5 comments
Closed

Navigator: Disable animation on popToTop #1027

blelem opened this issue Feb 18, 2019 · 5 comments
Labels
bug ext: navigation Relates to the navigation extension stale This ticket may be old, or may no longer be valid, and will be closed if no further activity occurs

Comments

@blelem
Copy link

blelem commented Feb 18, 2019

When calling popToTop on the navigator, the application flickers badly when the stack of pages to pop is anything more than 3 pages.

It seems like the navigator pops the top page (with animation), then pops the second page (with animation),... This all happens quickly, but not quickly enough, the effect is very visible : a lot of things are drawn on screen during short period of time.

That effect can be seen on both on Android and iOS apps. On the web client, there are no flickers, the popToTop transition is clean.

Am I missing some obvious parameter, or is this just a bug?

@erictraut
Copy link
Contributor

The author of the reactxp-navigator extension is no longer working on the project. You may need to dig into this yourself. If you find a fix, a contribution would be welcome.

@erictraut erictraut added the bug label Mar 9, 2019
@fbartho fbartho added the ext: navigation Relates to the navigation extension label Aug 9, 2020
@fbartho
Copy link
Contributor

fbartho commented Aug 9, 2020

@blelem is this still a concern? I'd be happy to merge a fix for this, but I don't currently use the navigation extension in my own apps.

@fbartho fbartho added the stale This ticket may be old, or may no longer be valid, and will be closed if no further activity occurs label Aug 9, 2020
@blelem
Copy link
Author

blelem commented Aug 10, 2020

Ah, a trip down the memory lane! This is not an issue for us anymore, we replaced reactxp-navigator with the react-router.
Feel free to close this error. I would recommend to mark reactxp-navigator as deprecated though, if a maintainer for that extention hasn't yet been found.

@fbartho
Copy link
Contributor

fbartho commented Aug 10, 2020

I've opened ticket #1234 to discuss deprecating!

@fbartho fbartho closed this as completed Aug 10, 2020
@fbartho
Copy link
Contributor

fbartho commented Aug 10, 2020

Thanks @blelem for your prompt response, as it makes this project easier to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ext: navigation Relates to the navigation extension stale This ticket may be old, or may no longer be valid, and will be closed if no further activity occurs
Projects
None yet
Development

No branches or pull requests

3 participants