Call event.stopPropagation() with keyDownEvents specified. #8077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rectified95
force-pushed
the
stop_propagation
branch
from
2c09a24 to
03542f1
Compare
jonthysell
approved these changes
Jun 22, 2021
| const _keyUp = (event: KeyEvent) => { | ||
| if (props.keyUpEvents && !event.isPropagationStopped) { | ||
| for (const el of props.keyUpEvents) { | ||
| if (event.nativeEvent.code == el.code && el.handledEventPhase == 3) { |
There was a problem hiding this comment.
Is there a constant somewhere we can use (or define) so as to not require a magic number here (and elsewhere)?
packages/@react-native-windows/tester/src/js/examples/Pressable/PressableExample.windows.js
Outdated
Show resolved
Hide resolved
rectified95
changed the title
rectified95
force-pushed
the
stop_propagation
branch
from
b599e12 to
017845e
Compare
rectified95
force-pushed
the
stop_propagation
branch
from
6856878 to
0e5a605
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
key(Down|Up)Eventsprops control whether the event handling should be left exclusively to the JS, or at least the native processing should stop at the native control emitting it. This is to match this behavior on the JS side, by hooking into theonKeyDown|Capturecallback and using event.stopPropagation() on the keys specified inkeyDownEvents.The change is in
Viewand so works forPressabletoo. I've made sure that the existing hooks inPressable, which special-caseSpacecontinue to work with this.Closes #5822
Microsoft Reviewers: Open in CodeFlow