Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Style Properties Handled in TextShadowNode Do Not Get Updates Unless App is Reloaded #8411

Closed
chiaramooney opened this issue Aug 11, 2021 · 2 comments

Comments

@chiaramooney
Copy link
Contributor

Environment

Run the following in your terminal and copy the results here.

  1. npx react-native --version: 5.0.1
  2. npx react-native info:

System:
OS: Windows 10 10.0.19042
CPU: (8) x64 Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
Memory: 50.83 GB / 63.84 GB
Binaries:
Node: 14.16.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.14.11 - C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK:
API Levels: 28, 29, 30
Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.3
System Images: android-29 | Intel x86 Atom_64, android-29 | Google Play Intel x86 Atom, android-30 | Google APIs Intel x86 Atom
Android NDK: Not Found
Windows SDK:
AllowDevelopmentWithoutDevLicense: Enabled
AllowAllTrustedApps: Enabled
Versions: 10.0.18362.0, 10.0.19041.0
IDEs:
Android Studio: Version 4.1.0.0 AI-201.8743.12.41.7199119
Visual Studio: 16.9.31328.270 (Visual Studio Enterprise 2019)
Languages:
Java: 1.8.0_282 - C:\Program Files\OpenJDK\openjdk-8u282-b08\bin\javac.EXE
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.1 => 17.0.1
react-native: 0.64.1 => 0.64.1
react-native-windows: ^0.64.0-0 => 0.64.14
npmGlobalPackages:
react-native: Not Found

  • Target Platform Version(s): 10 10.0.19042

  • Target Device(s): Desktop

  • Visual Studio Version: 2019

  • Build Configuration: Debug

Steps To Reproduce

Provide a detailed list of steps that reproduce the issue.

  1. Create an RNW application and run.
  2. Render a Text component.
  3. Add textTransform styling to Text component and save source code.
  4. Observe that textTransform styling does not appear via fast reload.
  5. Reload app.
  6. Observe textTransform styling now appears.

Expected Results

textTransform and backgroundColor styling should appear automatically in app upon javascript source code change.

Linked to #8395
#8408 may solve for backgroundColor prop.

Snack, code example, screenshot, or link to a repository:

textShadowScreenshot.mp4
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 11, 2021
@chrisglein chrisglein added Area: Text and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Aug 12, 2021
@chrisglein chrisglein added this to the 0.66 milestone Aug 12, 2021
@chiaramooney
Copy link
Contributor Author

Bug partially resolved via #8408; now need to extend changes from this PR to apply to textTransform prop as well.

@chrisglein chrisglein modified the milestones: 0.66, 0.67 Aug 31, 2021
@chiaramooney
Copy link
Contributor Author

Fast Refresh for textTransform fixed in #8454. Closing Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@chrisglein @chiaramooney and others