-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[appverifer] Playground crashes on master using direct debugging #6170
Comments
CC @acoates-ms @tido64 fyi, I'm synced to 489d342 Could this be related since it's got to do with initialization? |
I also see a TimingModule assert firing a lot. @NickGerleman I remember you recently worked on this code?
|
I'm not able to repro this locally in my own project running 0.63 + my fix:
I have seen the TimingModule assertion from time to time as well. Even on 0.62. |
TimingModule has two assertions that it can get a strong instance of Instance. My change removed once of them, where we were assuming the instance was alive in cases where it wouldn't necessarily be, and that was fine. The other, still present assertion should likely be removed as well. TimingModule methods are currently dispatched to the UI thread before execution, so the instance going away is still a possible case. |
Unable to repo when switching from web debugger, unchecking, and loading an instance. |
I'm running playground.exe with appverifier turned on, can you guys try to do the same? I'm able to get the Chakra crash fairly consistently which I hadn't gotten until yesterday. |
Re-ran my local project running 0.63.3 + 489d342 cherry-picked with App Verifier. Still no repro. I did hit an exception when toggling the element inspector but I can't get a reliable repro. |
thanks @tido64 . It's odd (but good! :) ) that you're not hitting it, maybe there's something different about my setup; I'm running what's in master so maybe that's it. |
@asklar It looks like there's been some issue reproducing this so we may need more environment info. Windows version combination maybe? If we think we have deep issues AppVerifier might catch is there somewhere we can expand coverage? Does E2Etest use it? Should we expand to run Playground? |
This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 14 days of this comment. |
Getting this crash a lot when running the App in Debug mode. Running on react-native 0.62.2 and react-native-windows 0.62.12 |
@exotexot the Timing related assertion is a bit of a red hearing, and itself should not be the root cause of a crash. The assertion will be removed in RNW 0.64, and should be ignorable. We did have some unrelated crashes on instance reload that were fixed in 0.63. If you're still seeing a crash on 0.63+, filing a new issue with details would definitely be appreciated. |
Still running on 0.62.12 and cannot really update at the Moment. But anyway thanks for providing more info on this topic. |
Load playground with rntester
disable web debugging
reload
app crashes with the stack below
The text was updated successfully, but these errors were encountered: