Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isComposing to onKeyDown/onKeyUp #5821

Open
harinikmsft opened this issue Aug 24, 2020 · 0 comments
Open

Add isComposing to onKeyDown/onKeyUp #5821

harinikmsft opened this issue Aug 24, 2020 · 0 comments
Labels
enhancement help wanted Needs: Dev Design Partner: Facebook Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Milestone

Comments

@harinikmsft
Copy link
Contributor

See comment for context. Copying from necolas's comment:

The event has an isComposing property set to true in that case. However, it's a bit more complicated (and inconsistent across browsers) than that and there has been discussion about what the timing of the composition events (compositionstart, compositionend [ref]) and when the isComposing property should be true. So in practice, on the web you also have to check whether the keyCode is a magic number 229 which indicates IME composition.

The work I'm doing on interactions will probably add onCompositionStart/End events and prevent all IME events from triggering onKeyDown and onKeyUp events, as the vast majority of developers aren't aware of IME and end up breaking things by acting on key events like Enter that are actually occurring during composition.

Some IME-related discussion here: necolas/react-native-web#1538 (comment)

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 24, 2020
@harinikmsft harinikmsft added this to the Backlog milestone Aug 24, 2020
@asklar asklar added help wanted Partner: Facebook Needs: Dev Design and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Aug 24, 2020
@chiaramooney chiaramooney added the Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Needs: Dev Design Partner: Facebook Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
None yet
Development

No branches or pull requests

3 participants