Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine How to Handle Breaking Change Causing Runtime Crash #4776

Closed
NickGerleman opened this issue May 2, 2020 · 3 comments
Closed

Determine How to Handle Breaking Change Causing Runtime Crash #4776

NickGerleman opened this issue May 2, 2020 · 3 comments

Comments

@NickGerleman
Copy link
Collaborator

NickGerleman commented May 2, 2020

#4755 removes a user-facing workaround we left in our template app. It has a nasty side-effect of causing any apps upgrading to see a crash if they don't remove the workaround.

This is a breaking change that could cause a lot of frustration, as the crash will appear somewhat cryptic. Following up with @vmoroz to understand if there are alternate fixes that could avoid the crash, or if we could convert the crash into a build-time error.

Pending that we have a couple options:

  1. Cherry-pick into 0.62 and try to rip the band-aid off early. This will break people using our preview, which is not ideal.
  2. Delay the change until 0.63, so that we can try to catch people with initial release notes.
  3. Invest in infrastructure like react-native-upgrade to mitigate before making the change (likely not possible)
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 2, 2020
@NickGerleman NickGerleman added this to the 0.62 (M5) milestone May 2, 2020
@asklar
Copy link
Member

asklar commented May 2, 2020

This might be even more relevant with WinUI3 since we'd be inheriting from MUX's Application instead of WUX's

@chrisglein
Copy link
Member

I think we should take #1, which is to break the preview. It's early enough in (one week out), so there's not too many on that yet.

Linking to this (general desire for upgrade helper) for reference: #3470

@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 4, 2020
@NickGerleman
Copy link
Collaborator Author

We decided to cherry pick into 0.62.0-preview.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants