Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement accessibilityActions #2765

Closed
9 tasks
jonthysell opened this issue Jul 12, 2019 · 3 comments · Fixed by #3475
Closed
9 tasks

Implement accessibilityActions #2765

jonthysell opened this issue Jul 12, 2019 · 3 comments · Fixed by #3475

Comments

@jonthysell
Copy link
Contributor

Right now, the only action a UIA client can make to a RNW app is Invoke and Toggle (which calls Invoke). The remaining actions we expose to UIA are no-ops:

  • Select
  • AddToSelection
  • RemoveFromSelection
  • Expand
  • Collapse
  • Toggle (re-do)

RN60 adds an accessibilityActions property, which lets you register an event handler to catch these invocations from UIA poking the native side. See docs here: https://facebook.github.io/react-native/docs/accessibility#accessibility-actions

Since it just uses string identifiers, this would be as simple as:

  • Storing the registered accessibilityActions event names via DynamicAutomationProperties
  • Storing a new AccessibilityActionsEventHandler property similar to AccessibilityInvokeEventHandler but with a name parameter
  • Having each UIA action list above check the registered names and if specific ones exist ("toggle", "select", etc) then fire the AccessibilityActionsEventHandler
@jonthysell jonthysell added this to the vNext Milestone 3 milestone Jul 12, 2019
@jonthysell jonthysell self-assigned this Jul 12, 2019
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 12, 2019
@harinikmsft harinikmsft added ready for dev and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jul 17, 2019
@harinikmsft
Copy link
Contributor

@jonthysell - please sync with @acoates-ms who is driving the upgrade to RN 0.60 and you can start making these changes in the branch where the upgrade is happening in order to avoid any throw away/conflicting work.

@chrisglein
Copy link
Member

With the RN60 upgrade almost wrapped up this should be ready for attention. @licanhua I'm adding it to your queue alongside another block of accessibility work.

@licanhua
Copy link
Contributor

licanhua commented Oct 15, 2019

@jonthysell , please help to revisit your proposal. I didn't see any value right now to implement accessibility-actions. Currently dynamicAutomationPeer is applied to View, and adding Toggle, expand action doesn't make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants