Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AppxBundle to be customised in msbuildprops #14122

Open
cjhines opened this issue Nov 19, 2024 · 1 comment
Open

Allow AppxBundle to be customised in msbuildprops #14122

cjhines opened this issue Nov 19, 2024 · 1 comment

Comments

@cjhines
Copy link

cjhines commented Nov 19, 2024

Summary

Because of the hard-coded AppxBundle=Never option, you cannot override it with the msbuildprops property.

https://github.com/microsoft/react-native-windows/blob/main/packages/%40react-native-windows/cli/src/utils/msbuildtools.ts#L112

Ideally this reads the msbuildprops option before setting a default.

Motivation

Generating an .appxbundle still has some use cases. Currently this requires a package to the library

Basic Example

No response

Open Questions

No response

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 19, 2024
@chrisglein chrisglein added this to the Backlog milestone Nov 21, 2024
@chrisglein
Copy link
Member

Interesting. Not sure why it's hardcoded to Never here. Seems like something that should be moved to the property sheets and allow an override.

@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants