Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Add feature for setting the X/Y pos of Modal on the screen #14068

Open
TatianaKapos opened this issue Nov 1, 2024 · 1 comment
Open

[Modal] Add feature for setting the X/Y pos of Modal on the screen #14068

TatianaKapos opened this issue Nov 1, 2024 · 1 comment
Assignees
@TatianaKapos
Labels
Area: Fabric Support Facebook Fabric Area: Modal enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Milestone
Next

Comments

@TatianaKapos
Copy link
Contributor

TatianaKapos commented Nov 1, 2024 •
edited by chrisglein
Loading

Summary

Currently Modal just open on the top-left of the users screen. Upstream's modal is defaulted to the middle of the application.

First step is to default our Modal to popup in the middle of the application.

Motivation

Implementation of Modal

Basic Example

No response

Open Questions

Second step of this is to figure out if we want to add windows-specific properties to allow the Modal to pop/up anywhere on the screen (may be outside of the application boundaries which is not a use-case upstream has)
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 1, 2024
@chrisglein chrisglein added this to the Next milestone Nov 4, 2024
@chrisglein chrisglein added Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) Area: Fabric Support Facebook Fabric Area: Modal New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) Area: Modal labels Nov 4, 2024
@TatianaKapos TatianaKapos self-assigned this Nov 4, 2024
@chrisglein
Copy link
Member

Some overlap with https://reactnative.dev/docs/modal#presentationstyle-ios, which is currently iOS only. That has some alignment options.

But as far as a default, centered would match expectation.

@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 4, 2024
@TatianaKapos TatianaKapos mentioned this issue Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TatianaKapos TatianaKapos

Labels
Area: Fabric Support Facebook Fabric Area: Modal enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
RNW New Architecture
Status: No status
Milestone
Next
Development

No branches or pull requests
2 participants
@chrisglein @TatianaKapos