Facebook 0.58.6 merge (with conflicts) #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes `react-native/no-inline-styles` eslint warnings in the `Libraries` module. Pull Request resolved: facebook#22161 Differential Revision: D12946899 Pulled By: TheSavior fbshipit-source-id: c97ffa50dd90529dabf30a3d2cb09476acc568cb
Summary: Allow a device to override the host to which to connect to for getting dev bundles, debugging etc. This is read from a system prop so it can be shared across all React Native apps and persists between app installs. Reviewed By: mdvacca Differential Revision: D10842213 fbshipit-source-id: d15b7d0255130090744d60ffb239778cba15e49c
Summary: Previously, asking for an instance of NativeModule from the native side gave `nil` if the lazy modules have not been loaded, which is not consistent with the access from JS. This at least attempts to force load the lazy modules when asked from native. p.s. one asks for a module by doing `[bridge moduleForClass:[FooBar class]]`. Reviewed By: spredolac Differential Revision: D12931640 fbshipit-source-id: 15d2dc574067d3386ef921512ce4bc837749dabd
Summary:
OS: Arch Linux
GCC Version: gcc (GCC) 8.2.1 20180831
Clang Version: 6.0.1 (tags/RELEASE_601/final)
Build Log Before Fix:
command: `buck build //:yoga`
```
Not using buckd because watchman isn't installed.
yoga/Yoga.cpp: In function ‘void YGZeroOutLayoutRecursivly(YGNodeRef)’:
yoga/Yoga.cpp:1854:51: error: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘struct YGLayout’; use assignment or value-initialization instead [-Werror=class-memaccess]
memset(&(node->getLayout()), 0, sizeof(YGLayout));
^
In file included from yoga/YGNode.h:11,
from yoga/Utils.h:9,
from yoga/Yoga.cpp:13:
yoga/YGLayout.h:12:8: note: ‘struct YGLayout’ declared here
struct YGLayout {
^~~~~~~~
cc1plus: all warnings being treated as errors
Build failed: Command failed with exit code 1.
stderr: yoga/Yoga.cpp: In function ‘void YGZeroOutLayoutRecursivly(YGNodeRef)’:
yoga/Yoga.cpp:1854:51: error: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘struct YGLayout’; use assignment or value-initialization instead [-Werror=class-memaccess]
memset(&(node->getLayout()), 0, sizeof(YGLayout));
^
In file included from yoga/YGNode.h:11,
from yoga/Utils.h:9,
from yoga/Yoga.cpp:13:
yoga/YGLayout.h:12:8: note: ‘struct YGLayout’ declared here
struct YGLayout {
^~~~~~~~
cc1plus: all warnings being treated as errors
When running <c++ preprocess_and_compile>.
When building rule //:yoga#compile-Yoga.cpp.o9b5477b5,default.
Parsing buck files: finished in 0.8 sec (100%)
Building: finished in 2.2 sec (100%) 10/10 jobs, 1 updated
Total time: 3.3 sec
```
Build Log After Fix
command: `buck build //:yoga`
```
Not using buckd because watchman isn't installed.
Parsing buck files: finished in 0.8 sec (100%)
Building: finished in 0.6 sec (100%) 1/1 jobs, 0 updated
Total time: 1.6 sec
```
All tests are passing
Pull Request resolved: facebook/yoga#823
Reviewed By: davidaurelio
Differential Revision: D10486023
Pulled By: passy
fbshipit-source-id: e9de734c3ce6c45ea4a8edd5d78206901d85ca84
Summary: Yoga's JNI bindings are usually loaded during class loading, and can stall the UI thread. Here, we try to mitigate the problem by adding the bindings to libcoldstart. Reviewed By: michalgr Differential Revision: D12956818 fbshipit-source-id: 9dda5cb6d26c2bae64606bc2d7c98ab8f7c05a30
Summary: Some console methods (like `groupCollapsed` or `clear`) are not supported by console.js polyfill and are not passed to the original console objects. Reviewed By: sahrens Differential Revision: D12900996 fbshipit-source-id: 1b2f487028e418ae934f631996eaaf63abdced82
Summary: This diff fixes an IllegalArgumentException when dismissing ReactModalHostView. I wasn't able to reproduce this error because this is likely created by a race condition. Reviewed By: axe-fb Differential Revision: D12916787 fbshipit-source-id: b071ffc4c251f2a613bb1270de005def56818376
…facebook#21885) Summary: This pull requests converts `TextInput` to an ES6 class, and in the process removes its usage of `prop-types` and `NativeMethodsMixin`. The code (and some relevant types) for the native components have been moved to `TextInputNativeComponent.js`. The rest of the flow proptypes have been moved to `TextInputTypes.js`. Pull Request resolved: facebook#21885 Reviewed By: RSNara Differential Revision: D10515754 Pulled By: TheSavior fbshipit-source-id: 5cfb25344385904b37a49582008c2a4b46db809d
Summary: Types were moved out of TextInput into TextInputTypes for better re-use. Fixing the internal callsites. This isn't much of a worry externally because these types aren't exposed as part of the public API Reviewed By: RSNara Differential Revision: D10517066 fbshipit-source-id: bade4285eafb3d7ab5ab1e4b0730c22d45925509
Reviewed By: yungsters Differential Revision: D10519823 fbshipit-source-id: 02368b670953a0275fa6495b0c73ef84403598cb
Reviewed By: yungsters Differential Revision: D12969854 fbshipit-source-id: c2fe2c46e538f8b5e3ea46257aef70d00bf14364
Summary: @public This sync includes the following changes: - **[3ff2c7ccd](facebook/react@3ff2c7ccd)**: Invalid actualDuration+treeBaseDuration for hidden+suspended trees (facebook#14065) //<Brian Vaughn>// - **[5afa1c4ed](facebook/react@5afa1c4ed)**: Tag MemoComponent with PerformedWork effectTag for DevTools Profiler (facebook#14141) //<Brian Vaughn>// - **[e27720d7f](facebook/react@e27720d7f)**: [Synchronous Suspense] Reuse deletions from primary tree (facebook#14133) //<Andrew Clark>// - **[aa1ffe4e7](facebook/react@aa1ffe4e7)**: Show deprecated context object warnings usage in ReactDOM server (facebook#14033) //<Dominic Gannaway>// - **[e3a7b9645](facebook/react@e3a7b9645)**: Make react-debug-tools a private package //<Andrew Clark>// - **[ba1984423](facebook/react@ba1984423)**: Update bundle sizes for 16.6.1 release //<Andrew Clark>// - **[b50e63ef5](facebook/react@b50e63ef5)**: Updating package versions for release 16.6.1 //<Andrew Clark>// - **[8f2c89e96](facebook/react@8f2c89e96)**: Make react-debug-tools a private package //<Andrew Clark>// - **[2aecbcd6f](facebook/react@2aecbcd6f)**: "functional component" -> "function component" (facebook#14123) //<locknono>// - **[b4608dd24](facebook/react@b4608dd24)**: Remove unused simulated flag parameter (facebook#14127) //<Nadav Kaner>// - **[3c69a1881](facebook/react@3c69a1881)**: Recover from errors with a boundary in completion phase (facebook#14104) //<Dan Abramov>// - **[b020fb114](facebook/react@b020fb114)**: Check correct commit phase props in fuzz tester (facebook#14129) //<Andrew Clark>// - **[b67c1a2ee](facebook/react@b67c1a2ee)**: Add DEV-only checks for assumption about instance properties (facebook#14128) //<Dan Abramov>// - **[f777d196e](facebook/react@f777d196e)**: Fix lazy() with defaultProps (facebook#14112) //<Dan Abramov>// - **[e4512991c](facebook/react@e4512991c)**: Fix unhiding in IE11 (facebook#14126) //<Sophie Alpert>// - **[affb2b50c](facebook/react@affb2b50c)**: Enable hooks in www test renderer, too //<Andrew Clark>// - **[0a0f503d5](facebook/react@0a0f503d5)**: Enable hooks in www build (facebook#14116) //<Andrew Clark>// - **[600651e68](facebook/react@600651e68)**: Restore the Hooks dispatcher after using SSR (facebook#14105) //<Dan Abramov>// - **[e9a2ec915](facebook/react@e9a2ec915)**: [suspense] Avoid double commit by re-rendering immediately and reusing primary children (facebook#14083) //<Andrew Clark>// - **[9d47143e8](facebook/react@9d47143e8)**: Implement {,un}hideInstance on RN renderer (facebook#14115) //<Sophie Alpert>// - **[ebdb47d2c](facebook/react@ebdb47d2c)**: DCE hooks code when flag is off (facebook#14111) //<Sophie Alpert>// - **[8b87ebf5b](facebook/react@8b87ebf5b)**: Rename .internal tests that aren't using internals (facebook#14109) //<Sophie Alpert>// - **[da04058a9](facebook/react@da04058a9)**: Use Function.prototype.apply in warningWithoutStack (facebook#14107) //<Sophie Alpert>// - **[fd1256a56](facebook/react@fd1256a56)**: Add Debug Tools Package for Introspection of Hooks (facebook#14085) //<Sebastian Markbåge>// - **[b305c4e03](facebook/react@b305c4e03)**: fix(react-dom): Fix crash during server render (facebook#14103) //<Tiago Nunes>// - **[d34d1c3ba](facebook/react@d34d1c3ba)**: react-reconciler: Update README.md (facebook#13953) //<Marcelo Jorge Vieira>// - **[6c404d82a](facebook/react@6c404d82a)**: Bugfix: Add back early return in setOffsets which was removed between 16.4.2 and 16.5.0. Fails in Edge in some scenarios. (facebook#14095) //<einarq>// - **[8eca0eff8](facebook/react@8eca0eff8)**: chore(tests): don't rely on jest fake timers scheduling real timers (facebook#14003) //<Simen Bekkhus>// - **[293fed899](facebook/react@293fed899)**: Warn for bad useEffect return value (facebook#14069) //<Sophie Alpert>// - **[ae196e84b](facebook/react@ae196e84b)**: Rename inputsAreEqual to areHookInputsEqual & move it to shared (facebook#14036) //<Mateusz Burzyński>// - **[c898020e0](facebook/react@c898020e0)**: Warn for forwardRef(memo(...)) (facebook#14070) //<Sophie Alpert>// - **[bf9fadfcf](facebook/react@bf9fadfcf)**: [Hooks] Remove dispatch callbacks (facebook#14037) //<Andrew Clark>// - **[8c67bbf18](facebook/react@8c67bbf18)**: [scheduler] Deadline object -> shouldYield (facebook#14025) //<Andrew Clark>// - **[e02086bfc](facebook/react@e02086bfc)**: Warn about variable number of dependencies //<Andrew Clark>// - **[b92cdef64](facebook/react@b92cdef64)**: Rename ReactHooks test suite //<Andrew Clark>// - **[6efbbe068](facebook/react@6efbbe068)**: Prettier //<Sophie Alpert>// - **[504576306](facebook/react@504576306)**: Swap order of function member in hook union types //<Andrew Clark>// - **[ddbfe2ed5](facebook/react@ddbfe2ed5)**: Add ESLint rule for React Hooks //<Caleb Meredith>// - **[acb489963](facebook/react@acb489963)**: Clear effect tags from a fiber that suspends in non-concurrent mode //<Andrew Clark>// - **[933b64710](facebook/react@933b64710)**: Disable hook update callback (2nd arg to setState/dispatch) //<Andrew Clark>// - **[5fc84efac](facebook/react@5fc84efac)**: Skip updating effect tag when skipping effect //<Sophie Alpert>// - **[9f34eb79a](facebook/react@9f34eb79a)**: Add readContext to ReactPartialRendererHooks //<Alex Taylor>// - **[f7cb9d2b2](facebook/react@f7cb9d2b2)**: Warn about useContext(Consumer|Provider) //<Dan Abramov>// - **[63cc7d2b3](facebook/react@63cc7d2b3)**: Test useContext in pure, forwardRef, and PureComponent //<Dan Abramov>// - **[3a7c6da8d](facebook/react@3a7c6da8d)**: Make effects actually work with memo //<Sophie Alpert>// - **[75a1c2e72](facebook/react@75a1c2e72)**: The Lost Effect, chapter 3 //<Sophie Alpert>// - **[55a4b1f37](facebook/react@55a4b1f37)**: memo supports Hooks //<Sophie Alpert>// - **[30aa4ad55](facebook/react@30aa4ad55)**: The Lost Effect, chapter 2 //<Sophie Alpert>// - **[b772e0e26](facebook/react@b772e0e26)**: "functional component" -> "function component" in hooks error messages //<Sebastian Markbåge>// - **[9e9e3970e](facebook/react@9e9e3970e)**: Warn for Hook set-state on unmounted component //<Sophie Alpert>// - **[6514697f0](facebook/react@6514697f0)**: Make sure deletions don't stop passive effects //<Sophie Alpert>// - **[dd019d34d](facebook/react@dd019d34d)**: Add support for hooks to ReactDOMServer //<Alex Taylor>// - **[11d0781ee](facebook/react@11d0781ee)**: Defer useEffect until after paint //<Andrew Clark>// - **[105f2de54](facebook/react@105f2de54)**: Put hooks behind feature flag //<Andrew Clark>// - **[7bee9fbdd](facebook/react@7bee9fbdd)**: Initial hooks implementation //<Andrew Clark>// - **[37c7fe0a5](facebook/react@37c7fe0a5)**: Update createRoot warning message based on `enableStableConcurrentModeAPIs` (facebook#14017) //<Rauno Freiberg>// - **[95f98a187](facebook/react@95f98a187)**: fix typo (facebook#13955) //<Joseph>// - **[e217f2f1a](facebook/react@e217f2f1a)**: Updated comment for getEventModifierState (facebook#13918) //<Patrick>// - **[275e76e83](facebook/react@275e76e83)**: Enable stable concurrent APIs flag for 16.7 alpha (facebook#13928) //<Brian Vaughn>// - **[8b97a9c36](facebook/react@8b97a9c36)**: Update bundle sizes for 16.6.0 release //<Dan Abramov>// - **[6c29eabf7](facebook/react@6c29eabf7)**: Updating package versions for release 16.6.0 //<Dan Abramov>// - **[d520b358d](facebook/react@d520b358d)**: Revert all package versions to 16.5.2 state //<Dan Abramov>// - **[8f1ec7649](facebook/react@8f1ec7649)**: Bump versions to beta.0 //<Dan Abramov>// - **[5055a83fa](facebook/react@5055a83fa)**: Revert "Revert "Updating dependencies for react-noop-renderer"" //<Dan Abramov>// - **[3e8b4a5b8](facebook/react@3e8b4a5b8)**: Revert "Updating dependencies for react-noop-renderer" //<Brian Vaughn>// - **[d8e03de4a](facebook/react@d8e03de4a)**: [react-cache] Remove `cache` as argument to `read` (facebook#13865) //<Andrew Clark>// - **[fefa1269e](facebook/react@fefa1269e)**: Revert accidentally committed existence check (facebook#13931) //<Andrew Clark>// - **[80a0c05ce](facebook/react@80a0c05ce)**: Removed react-cache from the bundle list for now (facebook#13930) //<BrianVaughn>// - **[915e4eab5](facebook/react@915e4eab5)**: Add "unstable_" prefix to react-cache and jest-react (facebook#13929) //<Brian Vaughn>// - **[cbbc2b6c4](facebook/react@cbbc2b6c4)**: [Synchronous Suspense] Suspending a class outside concurrent mode (facebook#13926) //<Andrew Clark>// - **[4947fcd76](facebook/react@4947fcd76)**: Fix lint (facebook#13923) //<Sebastian Markbåge>// - **[d75c69e0c](facebook/react@d75c69e0c)**: Remove unstable_ prefix from Suspense (facebook#13922) //<Sebastian Markbåge>// - **[c8ef2feda](facebook/react@c8ef2feda)**: Remove redundant word "the" (facebook#13919) //<John Lin>// - **[55444a6f4](facebook/react@55444a6f4)**: Try rendering again if a timed out tree receives an update (facebook#13921) //<Andrew Clark>// - **[04c4f2fce](facebook/react@04c4f2fce)**: [reconciler] ReactFiberNewContext import maxSigned31BitInt twice (facebook#13857) //<yongningfu>// - **[409e472fc](facebook/react@409e472fc)**: Add flow types in ReactControlledComponent (facebook#13669) //<Abdul Rauf>// - **[663835a43](facebook/react@663835a43)**: Add flow types in getEventModifierState (facebook#13909) //<Abdul Rauf>// - **[82710097f](facebook/react@82710097f)**: Add flow types in getNodeForCharacterOffset (facebook#13908) //<Abdul Rauf>// - **[b753f76a7](facebook/react@b753f76a7)**: Fix failing async tests in Node 10 //<Andrew Clark>// - **[b5c0852fd](facebook/react@b5c0852fd)**: Bump version to 16.6.0-beta.0 (facebook#13906) //<Dan Abramov>// - **[769b1f270](facebook/react@769b1f270)**: pure -> memo (facebook#13905) //<Dan Abramov>// - **[8ecd4bd4f](facebook/react@8ecd4bd4f)**: Add support for React.pure in ReactDOMServer (facebook#13855) //<Alex Taylor>// - **[15b11d23f](facebook/react@15b11d23f)**: Allow arbitrary types to be wrapped in pure (facebook#13903) //<Sebastian Markbåge>// - **[e770af7a3](facebook/react@e770af7a3)**: Add back accidentally deleted `break` to prevent fallthrough //<Andrew Clark>// - **[95a313ec0](facebook/react@95a313ec0)**: Unfork Lazy Component Branches (facebook#13902) //<Sebastian Markbåge>// - **[e16cdd5b1](facebook/react@e16cdd5b1)**: Always bail out timed out children even if they receive an update (facebook#13901) //<Andrew Clark>// - **[7268d97d2](facebook/react@7268d97d2)**: Centralize props memoization (facebook#13900) //<Sebastian Markbåge>// - **[0fc044679](facebook/react@0fc044679)**: Class component can suspend without losing state outside concurrent mode (facebook#13899) //<Andrew Clark>// - **[36db53822](facebook/react@36db53822)**: Bugfix for facebook#13886 (facebook#13896) //<Andrew Clark>// - **[6938dcaac](facebook/react@6938dcaac)**: SSR support for class contextType (facebook#13889) //<Sebastian Markbåge>// - **[fa65c58e1](facebook/react@fa65c58e1)**: Add readContext to SSR (facebook#13888) //<Sebastian Markbåge>// - **[d9a3cc070](facebook/react@d9a3cc070)**: React.lazy constructor must return result of a dynamic import (facebook#13886) //<Andrew Clark>// - **[d9659e499](facebook/react@d9659e499)**: Lazy components must use React.lazy (facebook#13885) //<Andrew Clark>// - **[0648ca618](facebook/react@0648ca618)**: Revert "React.pure automatically forwards ref" (facebook#13887) //<Sophie Alpert>// - **[4dd772ac1](facebook/react@4dd772ac1)**: Prettier :( //<Andrew Clark>// - **[98bab66c3](facebook/react@98bab66c3)**: Fix lint //<Andrew Clark>// - **[8ced545e3](facebook/react@8ced545e3)**: Suspense component does not capture if `fallback` is not defined (facebook#13879) //<Andrew Clark>// - **[b738ced47](facebook/react@b738ced47)**: Remove render prop option from Suspense (facebook#13880) //<Andrew Clark>// - **[55b827942](facebook/react@55b827942)**: Strict mode and default mode should have same Suspense semantics (facebook#13882) //<Andrew Clark>// - **[dac9202a9](facebook/react@dac9202a9)**: Hide timed-out children instead of deleting them so their state ispreserved (facebook#13823) //<Andrew Clark>// - **[4f0bd4590](facebook/react@4f0bd4590)**: Replacement of old links, by the new ones of the documentation. (facebook#13871) //<Pablo Javier D. A>// - **[7685b55d2](facebook/react@7685b55d2)**: Remove unstable_read() in favor of direct dispatcher call (facebook#13861)//<Dan Abramov>// - **[21a79a1d9](facebook/react@21a79a1d9)**: [schedule] Call ensureHostCallbackIsScheduled without args (facebook#13852) //<Trivikram Kamat>// - **[9ea4bc6ed](facebook/react@9ea4bc6ed)**: Fix false positive context warning when using an old React (facebook#13850) //<Dan Abramov>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions 4773fdf...3ff2c7c Reviewed By: sebmarkbage Differential Revision: D12955345 fbshipit-source-id: db12076758fe85a519074ca4fe3aa5ede6f4fd49
Summary: The first argument to `View.MeasureSpec.makeMeasureSpec` should be positive, but was being passed WRAP_CONTENT, which is negative. This diff fixes that. Reviewed By: achen1 Differential Revision: D6601683 fbshipit-source-id: 6d8499830f7b6da40848bab77d5ddbbb8a6fe44f
Summary: Pull Request resolved: pytorch/pytorch#13450 Pull Request resolved: facebook#22065 This diff enables -Wunused-private-field clang warning for Android builds and fixes all broken targets. Reviewed By: gkmhub Differential Revision: D12881793 fbshipit-source-id: 515555661e137be9e7b20eac9b5bdcb549d6a094
Summary: Updating lockfile to fix open source sanity test. Reviewed By: hramos Differential Revision: D12982917 fbshipit-source-id: 1e2f0abadf6e76b67215b70b8c71dea1c2c05bff
Summary: Using constants is safer than using strings. More details at D12843649 Reviewed By: sahrens Differential Revision: D8226521 fbshipit-source-id: 4c78c8dfe0bd658f46c8f81e50ceae9299fc6f3c
Summary: Before lazily-loading code existed, modules that were already loaded into memory took precedent over modules that were additionally registered. With lazily loading modules, instead of giving eagerly loaded modules precdence, it throws a redbox. This diff fixes that behavior. Reviewed By: PeteTheHeat Differential Revision: D12983805 fbshipit-source-id: fe4fcf35d5c2ca6f9f4e3f0d1d8c2ca35468fb1b
Summary: This diff fixes exception handling for Mounting of views, as soon as there is an exception we stop the mounting of views because from that point the UI View tree is going to be inconsistent with the ReactShadow tree from C++. We also stop the mounting of views when the host is paused, this allows us to not keep mounting views Reviewed By: shergin Differential Revision: D10510334 fbshipit-source-id: b0d3eba580ff92d8b8400244ec9d7c266db42ff9
Summary: AndroidSwipeRefreshLayout is rendered in the "Marketplace Your Items" screen altough it is disabled. This diff just temporary implements the AndroidSwipeRefreshLayout component as a View (similar to the iOS counterpart RefreshControl). Reviewed By: shergin Differential Revision: D10524049 fbshipit-source-id: 5df38fbdf1339b3857138d82a7100ec7f15854b3
Summary: This diff ensures that JS uses rootTags during navigation. A redbox will be rendered in debug mode when a non-rootTag is used during navigation. This change enables proper navigation for Fabric. Reviewed By: shergin Differential Revision: D10855198 fbshipit-source-id: a82aaa706cd62ce92143fa86d0a422c1ae439a50
Summary: This diff adds systrace support in the C++ side of Fabric Reviewed By: ejanzer Differential Revision: D12861373 fbshipit-source-id: 0291f3e406f239bbef3686ac0bba6e9f1c7eac57
Summary: This diff refactors the exeuction of 'AsyncEventBeat.induce()' as part of the delivery of events of Fabric Android implementation. The first part of the refactor moves the exeuction of onBatchEventDispatched out of the synchronization block for mEventsToDispatchLock. This lock is accessed from the UI Thread and executing the induce inside this synchronization block will affect UI, The second part of the refactor is to ensure that the exeuction of the C++ method AsyncEventBeat.induce() always happen in the JS Thread. Reviewed By: shergin Differential Revision: D12861387 fbshipit-source-id: e1cd03467274a1c5fcd04b0ac7efdbe7169b14c3
…iewAllocation method Summary: This diff exposes rootTag as part of SchedulerDelegate.schedulerDidRequestPreliminaryViewAllocation(). This will be necessary to be able to pool views per Surface in Android Reviewed By: shergin Differential Revision: D12875656 fbshipit-source-id: d2a8c1f9bcc6b14c17b34bf59085da44ae3c3416
Summary: Older versions of JSC (ios 11 and before) have a bug which I believe the ProtectionQueue mechanism tickles: https://bugs.webkit.org/show_bug.cgi?id=186827 This removes the ProtectionQueue and replaces it with an atomic flag to avoid calling unprotect after VM shutdown. This also fixes a race condition in shutdown. Reviewed By: danzimm Differential Revision: D12969953 fbshipit-source-id: fa3a14f3207be67a987ac3cf0fc1c9ce88837b0b
Summary: Fixes `react-native/no-inline-styles` warning for several examples. I'm limiting the size of this PR to make it simpler to review. Pull Request resolved: facebook#22123 Reviewed By: RSNara Differential Revision: D12929701 Pulled By: TheSavior fbshipit-source-id: 7a976f2208b557fcfda46d5b586b30652c550eb2
Summary: This was failing due to issues with refs, which we were able to fix and then finally due to some jest tests that were failing due to things being null that shouldn't be which I couldn't easily figure out. Reverting the stack until we can actually solve it, hopefully with additional tests. This was created by running: ``` $ hg backout c2fe2c46e538 fetching tree '' b9bbfc1925c6daf85ba3227d12f177aca9c0c054, based on 4257c76aefa84aaa17279e65aa7ca1174f4401e7, found via 02368b670953 connected to hg015.frc2.facebook.com 60 trees fetched over 2.91s fetching tree '' c3c304df13399f0f1a29a668242da454fc1d8a97, based on b9bbfc1925c6daf85ba3227d12f177aca9c0c054, found via c2fe2c46e538 7 trees fetched over 0.03s 1 files updated, 0 files merged, 0 files removed, 0 files unresolved commit 4270328:50a65c5c2e27 backs out commit 4266783:c2fe2c46e538 1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over 0.57s [[email protected] /data/sandcastle/boxes/instance-ide/xplat/js (50a65c5)]$ hg backout 02368b670953 fetching tree '' a46c8ca065f5b92cf375d7ed899fc5ca268ba4da, based on b9bbfc1925c6daf85ba3227d12f177aca9c0c054, found via bade4285eafb connected to hg024.frc2.facebook.com 27 trees fetched over 3.21s fetching tree '' 361548a090e81d18bab6f4fc16036c518cb4d7c1, based on a46c8ca065f5b92cf375d7ed899fc5ca268ba4da, found via bade4285eafb 41 trees fetched over 0.10s merging react-native-github/Libraries/Components/TextInput/TextInput.js 8 files updated, 1 files merged, 0 files removed, 0 files unresolved commit 4270329:dbaca0daf0ac backs out commit 4266782:02368b670953 14 files fetched over 7 fetches - (14 misses, 0.00% hit ratio) over 1.72s [[email protected] /data/sandcastle/boxes/instance-ide/xplat/js (dbaca0d)]$ hg backout bade4285eafb connected to hg030.frc2.facebook.com fetching tree '' 1b4a17164fdbfcad40139e46da4a9bfa8aa8def3, based on 361548a090e81d18bab6f4fc16036c518cb4d7c1, found via 5cfb25344385 7 trees fetched over 0.06s merging react-native-github/Libraries/Components/TextInput/TextInput.js 20 files updated, 1 files merged, 0 files removed, 0 files unresolved commit 4270330:2951740e5b32 backs out commit 4266781:bade4285eafb 33 files fetched over 14 fetches - (33 misses, 0.00% hit ratio) over 4.50s [[email protected] /data/sandcastle/boxes/instance-ide/xplat/js (2951740)]$ hg backout 5cfb25344385 connected to hg035.frc2.facebook.com merging react-native-github/Libraries/Components/TextInput/TextInput.js 0 files updated, 1 files merged, 2 files removed, 0 files unresolved commit 4270331:fffb4629a397 backs out commit 4266780:5cfb25344385 1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over 4.03s ``` Reviewed By: yungsters Differential Revision: D12989604 fbshipit-source-id: 703a7c9c1f5bdd710077e515bdff06fdb34502ec
Summary: It does not supported on Android and nobody uses it. I could find only one use cases: Very old versin of `SectionList` library (4 years ago). Reviewed By: sahrens Differential Revision: D12972361 fbshipit-source-id: a5dfef5e877e996adec2d4941417b4a2e727cfb7
Summary: Remove `force_static=true` from cxxreact:bridge, add dependencies to targets that were pulling them in from a statically linked cxxreact:bridge. Reviewed By: mhorowitz Differential Revision: D12914861 fbshipit-source-id: ff335b70e80d014538a8d5dc8c0bb7b095e7940e
… locations. (#299) Summary: <!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. --> **Summary** <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> This is an updated followup from facebook/metro#280, which we would still need to address the following assumptions about `/assets/`: https://github.com/facebook/metro/blob/e7deea19001d903a47868bb1fe6456bdc4b585e7/packages/metro/src/Server.js#L332 https://github.com/facebook/metro/blob/e7deea19001d903a47868bb1fe6456bdc4b585e7/packages/metro/src/Server.js#L379 https://github.com/facebook/metro/blob/e7deea19001d903a47868bb1fe6456bdc4b585e7/packages/metro/src/Server.js#L385 As pointed out by gdborton, there isn't currently a way to make this a configurable option. I am not certain how to find a proper workaround for `processRequest`. We found a temporary solution to have our express app pick up serving the assets from a publicPath as a middleware. But the change in this PR is still necessary to get it working fully. **Test plan** <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. --> - Will add tests once we figure out a comprehensive solution Pull Request resolved: facebook/metro#299 Reviewed By: rafeca Differential Revision: D12939229 Pulled By: mjesun fbshipit-source-id: 769c23468c5ac434f8319e5e7caaf46dd6453f2d
Summary: ShimmeringView is called: RTShimmeringView Android and ShimmeringView in iOS. This diff adds a mapping into ComponentDescriptorRegistry to temporary enable ShimmeringView component until we can unify names in JS. Reviewed By: sahrens Differential Revision: D12991351 fbshipit-source-id: 48e08b8021116221ccfd5f2512c76f65145baa2a
|
/azp run |
|
No pipelines are associated with this pull request. |
harrieshin
pushed a commit
that referenced
this pull request
Dec 7, 2021
* add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * Expose Pressability Hover config props in Pressable (facebook#32405) Summary: Several desktop forks (`react-native-macos`, `react-native-windows`, `react-native-web`) support mouse events, and while the stock Pressable component has the ability to support mouse events, it seems we aren't forwarding some props properly from Pressable -> Pressability. Pressability will calculate onMouseEnter / onMouseLeave event handlers based on the `onHoverIn/onHoverOut` callbacks passed into PressabilityConfig. https://github.com/facebook/react-native/blob/ad0d4534a751ed05f84ff971714c8f7a4d1deb3a/Libraries/Pressability/Pressability.js#L552 However, Pressable does not pass take in onHoverIn/onHoverOut props to pass to PressabilityConfig, so we can't take advantage of this functionality. This change should simply address that by passing the props through. <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Fixed] - Pressabel not passing hover props and event handlers to PressabilityConfig Pull Request resolved: facebook#32405 Test Plan: I fixed a similar issue in `react-native-macos` that I am now trying to contribute back upstream. #855 Reviewed By: yungsters Differential Revision: D31667737 Pulled By: sota000 fbshipit-source-id: f0bbe48302703bb2c45280d2afeec8d7a4586b6a * Extra followup changes * remove some extra fork differences from change * Add back type * update podfile Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
HeyImChris
pushed a commit
that referenced
this pull request
Jan 19, 2022
…iew (#941) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * remove performKeyEquivalent Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Jan 25, 2022
* add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * Use NSSwitch * remove change from my fork Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Jan 25, 2022
* add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * remove postinstall script * remove fork specific change * Update publish.yml Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
HeyImChris
pushed a commit
that referenced
this pull request
Jan 27, 2022
…in RCTV… (#972) * Don't override key presses "Space"/"Enter" to perform onClick in RCTView (#941) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * remove performKeyEquivalent Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * fix integration check Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Feb 19, 2022
* RCTSwitch: Use NSSwitch instead of NSButton (#924) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * Use NSSwitch * remove change from my fork Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * DynamicColorMacOS fixes (#1028) * Use initWithDynamicProvider + Add HC Support * Update log error * replace all references to 10.14 (#938) * Replace currentAppearance with currentDrawingAppearance on macOS 11+ (#1029) * Manually cherry-pick #1012 Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Apr 30, 2022
* add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * Fix alert * Delete extra file Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Jul 19, 2022
* add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * wip * wip * more wip * Home/End/OptionUp/OptionDown work * ensureItemAtIndexIsVisible works * Home/End work * Initial cleanup for PR * More cleanup * More cleanup * Make it a real prop * No need for client code * Don't move keyboard focus with selection * Update tags * Fix flow errors * Update colors, make ScrollView focusable * prettier * undo change * Fix flow errors * Clean up code + handle page up/down with new prop Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Jul 20, 2022
* Keyboard navigation in Flatlist (#1258) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * wip * wip * more wip * Home/End/OptionUp/OptionDown work * ensureItemAtIndexIsVisible works * Home/End work * Initial cleanup for PR * More cleanup * More cleanup * Make it a real prop * No need for client code * Don't move keyboard focus with selection * Update tags * Fix flow errors * Update colors, make ScrollView focusable * prettier * undo change * Fix flow errors * Clean up code + handle page up/down with new prop Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * yarn lint --fix Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Jul 20, 2022
* Keyboard navigation in Flatlist (#1258) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * wip * wip * more wip * Home/End/OptionUp/OptionDown work * ensureItemAtIndexIsVisible works * Home/End work * Initial cleanup for PR * More cleanup * More cleanup * Make it a real prop * No need for client code * Don't move keyboard focus with selection * Update tags * Fix flow errors * Update colors, make ScrollView focusable * prettier * undo change * Fix flow errors * Clean up code + handle page up/down with new prop Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * yarn lint --fix Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Jul 22, 2022
* add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * mouse selection works too * remove pull.yml Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Jul 22, 2022
* Keyboard navigation in Flatlist (#1258) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * wip * wip * more wip * Home/End/OptionUp/OptionDown work * ensureItemAtIndexIsVisible works * Home/End work * Initial cleanup for PR * More cleanup * More cleanup * Make it a real prop * No need for client code * Don't move keyboard focus with selection * Update tags * Fix flow errors * Update colors, make ScrollView focusable * prettier * undo change * Fix flow errors * Clean up code + handle page up/down with new prop Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * Flatlist keyboard navigation: Mouse can move selection (#1267) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * mouse selection works too * remove pull.yml Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * Update FlatList.js Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Jul 22, 2022
* Flatlist keyboard navigation: Mouse can move selection (#1267) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * mouse selection works too * remove pull.yml Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * Update FlatList.js Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 5, 2022
) * add pull yml * match handleOpenURLNotification event payload with iOS (microsoft#755) (microsoft#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (microsoft#11) * Deprecated api (microsoft#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855) * add pull yml * match handleOpenURLNotification event payload with iOS (microsoft#755) (microsoft#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (microsoft#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * remove pull yml Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Sep 12, 2022
* add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * remove boost-for-react-native * remove more * remove pull * add back header search path Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Sep 12, 2022
* add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * remove boost-for-react-native * remove more * remove pull * add back header search path Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
shwanton
referenced
this pull request
in shwanton/react-native-macos
Feb 13, 2023
* add pull yml * match handleOpenURLNotification event payload with iOS (microsoft#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (microsoft#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855) * add pull yml * match handleOpenURLNotification event payload with iOS (microsoft#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (microsoft#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * wip * wip * more wip * Home/End/OptionUp/OptionDown work * ensureItemAtIndexIsVisible works * Home/End work * Initial cleanup for PR * More cleanup * More cleanup * Make it a real prop * No need for client code * Don't move keyboard focus with selection * Update tags * Fix flow errors * Update colors, make ScrollView focusable * prettier * undo change * Fix flow errors * Clean up code + handle page up/down with new prop Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
shwanton
referenced
this pull request
in shwanton/react-native-macos
Feb 13, 2023
) * add pull yml * match handleOpenURLNotification event payload with iOS (microsoft#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (microsoft#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855) * add pull yml * match handleOpenURLNotification event payload with iOS (microsoft#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (microsoft#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * remove pull yml Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
NickGerleman
pushed a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 29, 2024
…acebook#46702) Summary: Pull Request resolved: facebook#46702 In facebook#44188, we've started combining multiple transactions in a single transaction, to meet React's atomicity requirements, while also dealing with the constraints of Android's Fabric implementation. This revealed a bug where in some scenarios (especially when using transitions), a node may be deleted and created during the same transaction. The current implementation of FabricMountingManager assumes it can safely reorder some operations, which it does to optimize the size of IntBufferBatch mount items. This is however incorrect and unsafe when multiple transactions are merged. **Example:** Differentiator output: ``` # Transaction 1 Remove microsoft#100 from microsoft#11 Delete microsoft#100 # Transaction 2 Create microsoft#100 Insert microsoft#100 into microsoft#11 ``` FabricMountingManager output ``` Remove microsoft#100 from microsoft#11 Insert microsoft#100 into microsoft#11 Delete microsoft#100 ``` Note that the create action is also skipped, because we only update `allocatedViewTags` after processing all mutations, leading FabricMountingManager to assume creation is not required. This leads to an invalid state in SurfaceMountingManager, which will be surfaced as a crash in `getViewState` on the next mutation that interacts with these views. Changelog: [Android][Fixed] Fix crash in getViewState when using suspense fallbacks. Reviewed By: sammy-SC Differential Revision: D63148523 fbshipit-source-id: 07ae26b2f7b7eba1b9784041dd3059b0956c035e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge facebook's 0.58.6 branch into ours.
Description of changes
Merge their fork into this branch. Merge conflicts are nearly all left in although I removed merge conflicts in about a dozen files or so already.
I'll keep fixing up the iOS/Mac merge conflicts and then shift to cross-plat files, but don't have a build environment to build/test Android or Windows, so help would be appreciated there.