Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream change to make description DEBUG only #1599

Closed
Saadnajmi opened this issue Dec 19, 2022 · 1 comment
Closed

Upstream change to make description DEBUG only #1599

Saadnajmi opened this issue Dec 19, 2022 · 1 comment
Labels
Needs: Triage 🔍

Comments

@Saadnajmi
Copy link
Collaborator

Saadnajmi commented Dec 19, 2022 •
edited
Loading

See various diffs in files like RCTModuleData.mm (line 573 at time of writing)
@Saadnajmi Saadnajmi converted this from a draft issue Dec 19, 2022
@ghost ghost added the Needs: Triage 🔍 label Dec 19, 2022
@Saadnajmi Saadnajmi mentioned this issue Dec 19, 2022
Merged
4 tasks
@Saadnajmi
Copy link
Collaborator Author

See my PR upstream facebook#36374 . When we sync this, we should remove the #if DEBUG checks from our fork

@Saadnajmi Saadnajmi reopened this Mar 21, 2023
@Saadnajmi Saadnajmi moved this from Done to In Progress in Upstreamable changes / removable diffs Mar 21, 2023
@Saadnajmi Saadnajmi moved this from In Progress to Done in Upstreamable changes / removable diffs Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs: Triage 🔍
Projects
Upstreamable changes / removable diffs
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Saadnajmi