RN0.43 capacity

[nihgwu]

No description provided.

[msftclas]

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

[chirag04]

related: #703

@nihgwu do you also need to add missing import import com.facebook.react.uimanager.ViewManager; in codepush.java?

[chirag04]

this is a blocker for us. cc @sergey-akhalkov

[nihgwu]

It's already there:
https://github.com/Microsoft/react-native-code-push/blob/master/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java#L8

[chirag04]

this is weird. maybe i accidentally removed it while making it work for RN 43 and added it back.

[ptomasroos]

Blocking here as well since we're using master.

[richardhuaaa]

Hi @sergey-akhalkov - could you or Max reproduce this issue, and then test the fix against 0.43, 0.41 and 0.39 (just looking at the breaking changes table) to ensure that it's backwards compatible? I assume it only applies to Android. Thank you :)

[sergey-akhalkov]

Hi @Silhouettes, I've reproduced the issue for RN 0.43.0-rc.1 for Android only and I can confirm that provided fix works well for this version of RN. I also can confirm that the fix has no backwards compatibility both with RN 0.39 and RN 0.41.

[nihgwu]

@sergey-akhalkov yes I just make it work for RN0.43
you can modify it or cut a new version for backward compatibility

[aslak-dirdal]

When will this be merged?

[rodrigopivi]

expecting this to get merged soon, it´s breaking for RN 0.43, which is already at pre release state

[richardhuaaa]

@aslakagens, it should be merged tomorrow or the day after

[sergey-akhalkov]

Merging this due to all seems to be ok, except this issue, that have place due to the React version 16.0.0-alpha.5 has been published on NPM. It can be fixed by downgrading React version to 16.0.0-alpha.3 in your package.json file and re-installing the dependencies.

[nihgwu]

@sergey-akhalkov I think that issue should have been resolved by this commit facebook/react-native@14c31d9

[sergey-akhalkov]

@nihgwu, thank you for clarification, the commit has been merged so I suppose the next release of RN will fix the issue.

[richardhuaaa]

We will publish this on npm the same day that RN 0.43 exits RC.

[mikeduminy]

@Silhouettes 0.43 has been released and the problem persists. Please can you publish the new version of this lib to npm?

[sergey-akhalkov]

@michaelduminy, we've released new version of React Native Module for CodePush: [email protected] (it's available via npm), please let me know if you see any issues or have any questions.

[mikeduminy]

Thanks @sergey-akhalkov & @Silhouettes! That has solved my compilation issue 👍

[gitfdy]

"react-native": "^0.41.2",
"react-native-code-push": "^4.1.0-beta",

@sergey-akhalkov build android

Execution failed for task ':react-native-code-push:compileReleaseJavaWithJavac'.

[max-mironov]

Hey there @gitfdy, please verify our compatibility table here. Seems that 0.41.2 is not compatible with CPRN 4.1.0-beta