Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking change on rn master breaks code push #703

Closed
chirag04 opened this issue Feb 14, 2017 · 2 comments
Closed

breaking change on rn master breaks code push #703

chirag04 opened this issue Feb 14, 2017 · 2 comments
Assignees
@sergey-akhalkov
Labels
enhancement fix-in-master

Comments

@chirag04
Copy link

latest version of code push is not compatible with master branch of RN as of today.

Refer:
facebook/react-native@ea6845c

Fix is simple:
change import to import com.facebook.react.modules.core.ReactChoreographer; in Codepush.java and CodepushNativemodule.java.
add missing import import com.facebook.react.uimanager.ViewManager; in codepush.java
@sergey-akhalkov
Copy link
Contributor

@chirag04, got it, thanks!

@chirag04 chirag04 mentioned this issue Mar 4, 2017
Merged
@sergey-akhalkov sergey-akhalkov self-assigned this Mar 6, 2017
@sergey-akhalkov
Copy link
Contributor

Closing this due to #735 has been merged. Please feel free to reopen if need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergey-akhalkov sergey-akhalkov

Labels
enhancement fix-in-master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chirag04 @sergey-akhalkov