Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android build.gradle namespace on AGP 8 #2743

Closed
Axiivy-Jaeseok opened this issue Aug 28, 2024 · 7 comments
Closed

Android build.gradle namespace on AGP 8 #2743

Axiivy-Jaeseok opened this issue Aug 28, 2024 · 7 comments

Comments

@Axiivy-Jaeseok
Copy link

Axiivy-Jaeseok commented Aug 28, 2024

Thanks so much for filing an issue or feature request! Please fill out the following (wherever relevant):

Steps to Reproduce

Hello, I received a notification from Google requiring me to update the TargetSDK of my Android app to version 34. To comply with this, I migrated my Gradle version from 7 to 8. However, I encountered a namespace error during the process. Upon investigation, I found that AGP 8 requires the namespace to be explicitly defined in the android section of the build.gradle file. The other SDKs I am using manage this by conditionally defining the namespace based on the Gradle version. As a temporary fix, I manually defined and added the namespace, as shown in the attached image. I’m wondering if there are any plans to address this issue in a future update.

Thank you for your attention.

Expected Behavior

What you expected to happen?

Actual Behavior

What actually happens?

  STACK TRACE AND/OR SCREENSHOTS

스크린샷 2024-08-28 오후 1 11 36

Reproducible Demo

Environment

  • react-native-code-push version: 8.3.1
  • react-native version: 0.72.4
  • iOS/Android/Windows version:
  • Does this reproduce on a debug build or release build?
  • Does this reproduce on a simulator, or only on a physical device?

(The more info the faster we will be able to address it!)

@MikhailSuendukov
Copy link
Contributor

Hello!
Thank you for reaching out to us. We will fix this issue and will keep you updated as soon as we have more details.

@Axiivy-Jaeseok
Copy link
Author

Axiivy-Jaeseok commented Aug 29, 2024

@MikhailSuendukov

Thank you for your support! I appreciate your quick response and efforts to resolve the issue. I’ll close this issue.

@burakkgunduzz
Copy link

I have the same problem and I hope the package maintainers update it quickly because 31th of this month is the last day. However, @Axiivy-Jaeseok did you manually add from node_modules/react-native-code-push/...?

@Axiivy-Jaeseok
Copy link
Author

@burakkgunduzz

Yes, I manually add namespace from node_modules/react-native-code-push/build.gradle

@sanjeevyadavIT
Copy link

sanjeevyadavIT commented Aug 29, 2024

@Axiivy-Jaeseok are you having trouble in creating build or crash is happening on App?

@MikhailSuendukov
Copy link
Contributor

We have successfully merged a pull request addressing this issue. The fix will be included in the upcoming release.

@MikhailSuendukov
Copy link
Contributor

A fix for this issue was released with the AppCenter SDK ReactNative v9.0.0, so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@sanjeevyadavIT @Axiivy-Jaeseok @burakkgunduzz @MikhailSuendukov and others