Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot build with [email protected] #2601

Closed
lafest opened this issue Oct 20, 2023 · 6 comments
Closed

cannot build with [email protected] #2601

lafest opened this issue Oct 20, 2023 · 6 comments

Comments

@lafest
Copy link

lafest commented Oct 20, 2023

I cannot build my app with [email protected]

because of facebook/react-native#37256 this change, import com.facebook.react.devsupport.DevInternalSettings; makes error. so, I resolved this error with below patch.

	diff --git a/node_modules/react-native-code-push/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java b/node_modules/react-native-code-push/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java
index 923dd15..f5e4cc4 100644
--- a/node_modules/react-native-code-push/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java
+++ b/node_modules/react-native-code-push/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java
@@ -10,8 +10,8 @@ import com.facebook.react.ReactPackage;
 import com.facebook.react.bridge.JavaScriptModule;
 import com.facebook.react.bridge.NativeModule;
 import com.facebook.react.bridge.ReactApplicationContext;
-import com.facebook.react.devsupport.DevInternalSettings;
 import com.facebook.react.devsupport.interfaces.DevSupportManager;
+import com.facebook.react.modules.debug.interfaces.DeveloperSettings;
 import com.facebook.react.uimanager.ViewManager;

 import org.json.JSONException;
@@ -152,7 +152,7 @@ public class CodePush implements ReactPackage {
         if (instanceManager != null) {
             DevSupportManager devSupportManager = instanceManager.getDevSupportManager();
             if (devSupportManager != null) {
-                DevInternalSettings devInternalSettings = (DevInternalSettings)devSupportManager.getDevSettings();
+                DeveloperSettings devInternalSettings = devSupportManager.getDevSettings();
                 Method[] methods = devInternalSettings.getClass().getMethods();
                 for (Method m : methods) {
                     if (m.getName().equals("isReloadOnJSChangeEnabled")) {

But, I have no idea how to support 0.73 and also below versions. can anybody help this issue?

Environment

  • react-native-code-push version: 8.0.0
  • react-native version: 0.73.0-rc.2
  • iOS/Android/Windows version: Android 31
  • Does this reproduce on a debug build or release build? debug
  • Does this reproduce on a simulator, or only on a physical device? simulator

(The more info the faster we will be able to address it!)

@MikhailSuendukov
Copy link
Contributor

Hello and thanks for contacting us, we are looking into this issue

@idan666
Copy link

idan666 commented Nov 15, 2023

Is there an update on the new React Native version support?
There are compatibility issues arising with Android 14, which require React Native to be upgraded to latest stable version.

@griarman
Copy link

any updates?

@RayKay91
Copy link

Also need a fix...

@Dallas62
Copy link

Dallas62 commented Jan 3, 2024

#2617

@DmitriyKirakosyan
Copy link
Contributor

Fixed in version 8.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants