Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc_msg_payload_serialize_default_format is set to DSF_THRIFT_BINARY, which could fail apps using protobuf. #211

Open
linmajia opened this issue Apr 3, 2019 · 0 comments
Labels

Comments

@linmajia
Copy link
Contributor

linmajia commented Apr 3, 2019

In function message_ex* message_ex::create_request(), core/src/rpc_message.cpp, line 427. Therefore if an app uses protobuf (e.g. tutorial/counter.proto), the generated function inline void marshall(binary_writer& writer, const GType &value, dsn_msg_serialize_format fmt) from macro GENERATED_TYPE_SERIALIZATION could throw assertion.

@linmajia linmajia added the bug label Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant