Rename shadowed file code action doesn't show up

[StellaHuang95]

Environment data

• Pylance version: 2024.8.104

Repro Steps

1. Clone pylance-release
2. Open pylance-release\testing\single folder in VS Code
3. Open codeaction.py, place cursor on mailbox

Expected behavior

Lightbulb shows up and trigger quick fix and Rename "...mailbox" to "...mailbox_x" entry is listed

Actual behavior

Rename "...mailbox" to "...mailbox_x" code action isn't showing up

[StellaHuang95]

That's because the reportShadowedImports is not set in pyrightconfig.json so it uses the default value off. However, this doesn't explain why the issue doesn't occur with previous Pylance versions, where I also don't have any diagnostic rules set in settings.json.

[rchiodo]

Default is on in pylance. That's the default for that setting. But since pyrightconfig.json is present all defaults come from that.

[StellaHuang95]

Why is this diagnostic rule special-cased in Pylance?

[rchiodo]

Because Eric didn't want that behavior for the command line in Pyright. So we override it in Pylance.