Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"on pin pulse" block and variables as inputs #5878

Closed
microbit-carlos opened this issue Aug 29, 2024 · 1 comment · Fixed by #5879
Closed

"on pin pulse" block and variables as inputs #5878

microbit-carlos opened this issue Aug 29, 2024 · 1 comment · Fixed by #5879
Assignees
Labels

Comments

@microbit-carlos
Copy link
Collaborator

microbit-carlos commented Aug 29, 2024

A continuation of the discussion from:

With the latest pin changes (thanks @sae220 and @riknoll!), we have the "on pin pulse" block which can take an input to indicate which pin to select.

With the shadow block we can select any available pin:
image

We can also add a "digital pin" or "analog pin" block as an input:

image

But when adding a variable we encounter a warning, for the reasons listed in #5752 (comment):
image

So, it's not too clear what might be the advantage to have a shadow block in this block, if dropping a variable cannot work and dropping a "digital pin" or "analog" pin block does not offer any advantages over the shadow block itself.

To avoid confusion with the variable warning perhaps we should revert this block to simply have a dropdown like in Makecode v6?
image

@riknoll
Copy link
Member

riknoll commented Aug 29, 2024

yeah, i think it makes sense to revert this single block. i'll open a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants