-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using umlaute in function names breaks the .hex #173
Comments
I can not reproduce it. Can you provide a sample hex file and check if this also appears in Firefox and Chrome (I suppose you used safari)? Does this also happen in https://makecode.microbit.org/#editor ? |
It has been the case on Windows 10 with Edge on several computers and is also the case on makecode.microbit.org (from what has been reported). |
Well, can reproduce it now. The error message in Edge claims "Out of Memory".
@pelikhan I guess this is something that has to be fixed in https://github.com/microsoft/pxt |
A simpler version (less special characters) is loading the Simulator and seem to work: https://makecode.microbit.org/_2HcbJRbcdHya |
Its working well in https://arcade.makecode.com/45552-86181-46605-09798, so I guess it is not a pxt thing, but something pxt-calliope and pxt-microbit having in common. |
This arcade example crashes, when you rename the function to Fußgänger-Ampel. Then go to Home, open the saved project again, change from blocks to javascript and back ... the browser will crash with out of memory. |
From the function name 'ß-A' the '-' is removed in javascript to 'ßA'. This '-' can not be restored to blocks when the name includes 'ß' and the project is re-opened. The function with this name must not be called, it must only exist. |
Is the umlaut problem fixed in the current version of MakeCode? Here is my test program https://makecode.calliope.cc/_2F62y97F4Yku |
In the current version is no umlaut problem, when I write new code. When I import the old hex-File with this problem, the Edge Browser crashes again. |
What happens when you import my linked project https://makecode.calliope.cc/_2F62y97F4Yku |
When I click the link Code bearbeiten it opens in MakeCode. (My old hex-File mini-Ampel5.hex was saved on 21.03.2022.) |
Is it possible to edit the linked test project? |
I can edit your project in blocks and in javascript, change the values, upload an see it on the display. It works also whe I rename the function with spaces: usingÜ and ÄinFunctionName |
@elssner makecode.calliope works fine, but you use arcade.makecode.com |
You can make use of Umlaute (such as ö, ä, ü, or even ß) in function names.
When saving a hex file from this and trying to open it, the browser window becomes unresponsive after a while. All changes (before it doesn't react anymore) are not saved to the file.
It would be good if certain letters could not be used (and/or a message appears when using them) in such instances.
The text was updated successfully, but these errors were encountered: