Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Tools tip for dictionary shows object hash #45

Closed
karthiknadig opened this issue Feb 6, 2018 · 6 comments
Closed

Tools tip for dictionary shows object hash #45

karthiknadig opened this issue Feb 6, 2018 · 6 comments
Assignees
Milestone

Comments

@karthiknadig
Copy link
Member

image

@karthiknadig karthiknadig changed the title Tools tip for dictionary shows object address Tools tip for dictionary shows object hash Mar 11, 2018
@int19h int19h added this to the VSC Stable milestone Mar 21, 2018
@MikhailArkhipov MikhailArkhipov modified the milestones: VSC Stable, June 2018 May 2, 2018
@MikhailArkhipov MikhailArkhipov modified the milestones: June 2018.1, Future May 17, 2018
@fabioz
Copy link
Contributor

fabioz commented Aug 16, 2018

As a note, I've started to take a look at this issue.

@fabioz
Copy link
Contributor

fabioz commented Aug 17, 2018

After investigating it, this will actually be a big change in pydevd

The main issue is that the API to get variables only provides users with a way to get a dictionary of key->value which will already be the final representation of the object (and what's shown to the user is later used to get the variable again).

To fix this, both the protocol as well as the internal API will need to be changed to allow for object identifiers to be given to variables so that the what's shown to the user does not need to contain that information (which means that the protocol has to be changed to send and receive such an id to get the variable and that mapping of ids->variables must be kept while the thread is suspended).

Given that this will touch a good number of places, my suggestion would be already fixing the other related issue which is being able to have a different formatter per-request and try to use json instead of xml as a payload for the responses which return variables.

My estimate is around 12 days to have this complete. I'll already start on it, but as it'll take a while until it's actually integrated let me know if there's something I should take a look first given that this will take longer than I anticipated.

On the good side, the solution is closer to what the debug adapter protocol expects, so, the integration in ptvsd will need to do less work and formatters will be more flexible than now.

@karthiknadig
Copy link
Member Author

I will go over the issues and let you know.

@DonJayamanne
Copy link
Contributor

Though this is a dup of #1114, please note the values are more prominent in VSC, hence the issue is worse in VSC than in VS.
In VS you get the values only as tooltips, where as in VSC they are always visible.
The fact that it manifests it self differently in VSC could impact the priority of this issue

@karthiknadig
Copy link
Member Author

The thing is this is how pydevd formats dictionaries. When that part is fixed, it will fix this in all places. Do let us know if we need to bump the priority on this.

@karthiknadig
Copy link
Member Author

Fixed:
image

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants