Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Add support for terminateDebugee in disconnect request #136

Closed
DonJayamanne opened this issue Feb 27, 2018 · 3 comments
Closed

Add support for terminateDebugee in disconnect request #136

DonJayamanne opened this issue Feb 27, 2018 · 3 comments

Comments

@DonJayamanne
Copy link
Contributor

@karthiknadig requested in #134 (comment)

I think terminateDebuggee argument should be handled here as well.

@MikhailArkhipov
Copy link

What functionality does it affect?

@MikhailArkhipov MikhailArkhipov modified the milestones: VS stable, June 2018 May 2, 2018
@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented May 2, 2018

What functionality does it affect?

Stopping the debugger and optionally killing the debugee. Basically this controls what happens when the user stops debugging

This is required in VS.
VSC does not use this. In fact, even if we support this functionality VSC doesn't seem to pass this flag.

@MikhailArkhipov MikhailArkhipov modified the milestones: June 2018.1, Future May 31, 2018
@karthiknadig karthiknadig removed this from the Future milestone Sep 14, 2018
@gramster
Copy link
Member

gramster commented Sep 3, 2019

Already done in refactoring.

@gramster gramster closed this as completed Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants