Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Passing launch configuration (aka debugOptions) to the debugger #131

Closed
DonJayamanne opened this issue Feb 27, 2018 · 3 comments
Closed

Comments

@DonJayamanne
Copy link
Contributor

How do we plan on passing debug options to the new Debugger?
I'm referring to the PythonDebugOptions.

  • Option 1: Pass via command line arguments (ugly and old way of doing things)
  • Option 2: Use the protocol to pass the necessary configuration/options

I'm of the opinion we should go down the path of Option 2, if we want to truly embrace the protocol.

Here's an example:

  • Consider the RedirectOutput option
  • We could pass this via the launch request
  • This information is then passed onto PyDevD via the pydevd_request method

Note: The launch request is whats meant to contain the configuration options/settings for the debugger.

@DonJayamanne DonJayamanne changed the title Launch configuration (aka debugOptions) Passing launch configuration (aka debugOptions) to the debugger Feb 27, 2018
@int19h
Copy link
Contributor

int19h commented Feb 27, 2018

It'll have to be a message to support remote attach, since there's no command line there. But I think it's not high-pri until we require that scenario.

@DonJayamanne
Copy link
Contributor Author

It'll have to be a message to support remote attach

the attach request supports this.

not high-pri until we require that scenario.

I've raised this issue, as we'll (VSC) need the ability to pass these launch configurations to PTVSD.
Here's an excerpt from the docs:

Since arguments for both requests are highly dependent on a specific debug adapter implementation, the Debug Adapter Protocol does not prescribe any arguments. Instead VS Code passes all arguments from the user's launch configuration to the launch or attach requests. A schema for IntelliSense and hover information for these attributes can be contributed in the package.json of the debug adapter extension. This will guide the user when creating or editing launch configurations.

@DonJayamanne
Copy link
Contributor Author

We're both in agreement about that fact that it'll have to be a message, hence I'm closing this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants