Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise pointer requirements #47

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

mingxwa
Copy link
Collaborator

@mingxwa mingxwa commented Nov 30, 2023

This change revised requirements of pointers with std::to_address() function template in C++20 to avoid inventing another "pointer requirements". No functional change.

Before: Concept proxiable requires *p be well-formed, and for each dispatch type D defined by typename F::dispatch_types, D meets the Dispatch requirements of type decltype(*p).
After: Concept proxiable requires std::address_of(p) be well-formed, and for each dispatch type D defined by typename F::dispatch_types, D meets the Dispatch requirements of type decltype(*std::address_of(p)).

The definition of class templates pro::details::sbo_ptr and pro::details::deep_ptr are updated accordingly.

@mingxwa mingxwa requested a review from tian-lt November 30, 2023 08:34
@mingxwa mingxwa merged commit 3f9626a into microsoft:main Dec 1, 2023
4 checks passed
@mingxwa mingxwa deleted the user/mingxwa/revise-pointer branch December 1, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants