Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Prompty: export Exception types and original exception #3814

Open
ianchi opened this issue Oct 13, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@ianchi
Copy link

ianchi commented Oct 13, 2024

Is your feature request related to a problem? Please describe.
Original OpenAI Exceptions are wrapped in new types, but the types are not exported, and so you cannot catch specific error without importing private member

Describe the solution you'd like
Export ExceedMaxRetryTimes and in all other cases the original exception.

Describe alternatives you've considered
Directly raise the original exception. I'm not sure what is the value of raising WrappedOpenAIError, which is much more difficult to letar distinguish between subtypes and breaks the standard except ExceptionType approach.

You also loose some detail information as there is no way of accessing the original exception, unless accessing private members.

@ianchi ianchi added the enhancement New feature or request label Oct 13, 2024
Copy link

Hi, we're sending this friendly reminder because we haven't heard back from you in 30 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 7 days of this comment, the issue will be automatically closed. Thank you!

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Nov 12, 2024
@ianchi
Copy link
Author

ianchi commented Nov 16, 2024

Hi, any comments on this?

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue/pull request label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant