From a81a91ec32ea26d6245338a29e6e1f9e44d8fa8e Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Mon, 13 Nov 2023 13:36:20 -0800
Subject: [PATCH] chore: remove fake `error` from expect calls

We used to have a fake `error` property, so that trace viewer shows failed expectes as such.
Today, we have a step for each expect that contains a proper error. Sending the fake error
to the client confuses language ports.
---
 .../playwright-core/src/server/dispatchers/frameDispatcher.ts   | 2 --
 1 file changed, 2 deletions(-)

diff --git a/packages/playwright-core/src/server/dispatchers/frameDispatcher.ts b/packages/playwright-core/src/server/dispatchers/frameDispatcher.ts
index c8fd0c9e24651..b8e69d070d83c 100644
--- a/packages/playwright-core/src/server/dispatchers/frameDispatcher.ts
+++ b/packages/playwright-core/src/server/dispatchers/frameDispatcher.ts
@@ -256,8 +256,6 @@ export class FrameDispatcher extends Dispatcher<Frame, channels.FrameChannel, Br
     const result = await this._frame.expect(metadata, params.selector, { ...params, expectedValue });
     if (result.received !== undefined)
       result.received = serializeResult(result.received);
-    if (result.matches === params.isNot)
-      metadata.error = { error: { name: 'Expect', message: 'Expect failed' } };
     return result;
   }
 }