Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Docs have wrong evaluation argument type #3281

Closed
pavelfeldman opened this issue Aug 4, 2020 · 2 comments · Fixed by #3358
Closed

[BUG] Docs have wrong evaluation argument type #3281

pavelfeldman opened this issue Aug 4, 2020 · 2 comments · Fixed by #3358
Assignees
@dgozman

Comments

@pavelfeldman
Copy link
Member

It is <[Serializable]|[JSHandle]>, while in reality it can be array or object with jshandle values.
@pavelfeldman
Copy link
Member Author

Also, it'd be nice to clarify the meaning of "Object" - sometimes it means "Any" and sometimes it means dictionary. Not sure how we are generating TS types from it - I could not generate it from api.md alone for Python.

@pavelfeldman
Copy link
Member Author

consoleMessage.location() claims all fields are required, while they are optional. But existing linter does not bother checking it...

This was referenced Aug 4, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgozman dgozman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(api): explicit nulls, use Serializable and EvaluationArgument more
2 participants
@pavelfeldman @dgozman