Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] for the jest portion of the tests, we should handle sigint. #3001

Closed
pavelfeldman opened this issue Jul 17, 2020 · 3 comments
Closed

[Internal] for the jest portion of the tests, we should handle sigint. #3001

pavelfeldman opened this issue Jul 17, 2020 · 3 comments
Assignees
@JoelEinbinder

Comments

@pavelfeldman
Copy link
Member

No description provided.

@rwoll
Copy link
Member

rwoll commented Jul 22, 2020

+1: I rebased some work off of main which pulled in the new runners. I ran npm run test without realizing it would run all the tests—including the headful tests. I tried to stop it with a sigint, but ultimately had to force quit the terminal.

@JoelEinbinder JoelEinbinder mentioned this issue Jul 23, 2020
Merged
@JoelEinbinder
Copy link
Contributor

This is mostly fixed, although there a few tests which launch their own browsers that will still leak zombies if interrupted.

@pavelfeldman pavelfeldman removed the v1.3 label Jul 27, 2020
@aslushnikov
Copy link
Collaborator

Jest is gone from our tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoelEinbinder JoelEinbinder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aslushnikov @pavelfeldman @JoelEinbinder @rwoll