Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] page.waitForLoadState('networkidle') fails with nested cross origin iframes #2258

Closed
k15a opened this issue May 15, 2020 · 4 comments · Fixed by #2284
Closed

[BUG] page.waitForLoadState('networkidle') fails with nested cross origin iframes #2258

k15a opened this issue May 15, 2020 · 4 comments · Fixed by #2284
Assignees
@dgozman

Comments

@k15a
Copy link

k15a commented May 15, 2020 •
edited
Loading

Context:

  • Playwright Version: 1.0.2
  • Operating System: Mac
  • Node version: v12.16.3
  • Browser: Chromium

Code Snippet

Reproduction is here: https://github.com/k15a/pw-site-isolation-wait-for-bug

Describe the bug

If there are two nested iframes that run on different origins (e.g. index.html loads an iframe with src https://domain1.com/iframe.html which loads an iframe with src https://domain2.com/iframe.html) then using page.waitForLoadState('networkidle') doesn't work unless you turn off IsolateOrigins and site-per-process.

It looks like the two requests to the iframe.html files never finish.

Kapture 2020-05-15 at 13 29 31
@k15a k15a mentioned this issue May 15, 2020
Closed
@dgozman
Copy link
Contributor

dgozman commented May 18, 2020

I can repro this, thank you for filing!

@dgozman dgozman mentioned this issue May 18, 2020
Merged
@dgozman dgozman self-assigned this May 18, 2020
@dgozman
Copy link
Contributor

dgozman commented May 19, 2020

Should be fixed in the 1.1 release.

@scottadamsmith
Copy link

Do you know when the 1.1 version will be available? I am only seeing 1.0.2 when installing latest from NPM. Thanks!

@k15a
Copy link
Author

k15a commented Jun 8, 2020

@scottadamsmith You can use @next to install a pre-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgozman dgozman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(oopif): adopt main requests into oopifs
3 participants
@scottadamsmith @dgozman @k15a