From 7155356e3cee47eb51d7cb1c2bc42e82cdfc8dcf Mon Sep 17 00:00:00 2001
From: Max Schmitt <max@schmitt.mx>
Date: Mon, 30 Sep 2024 20:33:37 +0200
Subject: [PATCH] cherry-pick(#32880): chore: unflake 'should record'

---
 .../playwright-core/src/server/recorder/recorderCollection.ts   | 2 ++
 tests/library/debug-controller.spec.ts                          | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/packages/playwright-core/src/server/recorder/recorderCollection.ts b/packages/playwright-core/src/server/recorder/recorderCollection.ts
index d61f727fa8688..b5216d7382e08 100644
--- a/packages/playwright-core/src/server/recorder/recorderCollection.ts
+++ b/packages/playwright-core/src/server/recorder/recorderCollection.ts
@@ -126,6 +126,8 @@ export class RecorderCollection extends EventEmitter {
   }
 
   private _fireChange() {
+    if (!this._enabled)
+      return;
     this.emit('change', collapseActions(this._actions));
   }
 }
diff --git a/tests/library/debug-controller.spec.ts b/tests/library/debug-controller.spec.ts
index 2da0ee1bf3744..cdc579fed238a 100644
--- a/tests/library/debug-controller.spec.ts
+++ b/tests/library/debug-controller.spec.ts
@@ -188,9 +188,9 @@ test('test', async ({ page }) => {
   await page.getByRole('button', { name: 'Submit' }).click();
 });`
   });
-  const length = events.length;
   // No events after mode disabled
   await backend.setRecorderMode({ mode: 'none' });
+  const length = events.length;
   await page.getByRole('button').click();
   expect(events).toHaveLength(length);
 });