From 080d4269c273a6e9a94e3967a47da2fe68f5f14c Mon Sep 17 00:00:00 2001 From: Vance Morrison Date: Fri, 15 Dec 2017 12:52:27 -0800 Subject: [PATCH] Fix build warnings --- src/PerfView/App.cs | 26 +++++++++++++------------ src/TraceEvent/Stacks/RecursionGuard.cs | 3 +-- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/src/PerfView/App.cs b/src/PerfView/App.cs index aa14cd91f..338ae5fad 100755 --- a/src/PerfView/App.cs +++ b/src/PerfView/App.cs @@ -979,20 +979,22 @@ private static bool CreateConsole() }); return true; -#endif +#endif } +#if !DOTNET_CORE static Thread s_threadToInterrupt; static int s_controlCPressed = 0; +#endif - #endregion - #endregion - } +#endregion +#endregion + } - /// - /// APIs for logging usage data and feedback. - /// - public static class AppLog + /// + /// APIs for logging usage data and feedback. + /// + public static class AppLog { /// /// Returns true if you have access to the file share where we log feedback @@ -1146,7 +1148,7 @@ public static string BuildDate } } - #region private +#region private private static string FeedbackServer { get { return "clrMain"; } } @@ -1189,7 +1191,7 @@ private static bool WriteFeedbackToLog(string filePath, string message) } return false; } - #endregion +#endregion } /// @@ -1235,9 +1237,9 @@ protected override void Dispose(bool disposing) m_terseLog.Dispose(); m_verboseLog.Dispose(); } - #region private +#region private TextWriter m_verboseLog; TextWriter m_terseLog; - #endregion +#endregion } } diff --git a/src/TraceEvent/Stacks/RecursionGuard.cs b/src/TraceEvent/Stacks/RecursionGuard.cs index 9bf587d8d..881bec1b1 100644 --- a/src/TraceEvent/Stacks/RecursionGuard.cs +++ b/src/TraceEvent/Stacks/RecursionGuard.cs @@ -3,8 +3,7 @@ namespace Microsoft.Diagnostics.Tracing.Stacks { /// - /// This structure provides a clean API for a lightweight recursion stack guard to prevent - /// . + /// This structure provides a clean API for a lightweight recursion stack guard to prevent StackOverflow exceptions /// internal struct RecursionGuard {