Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Data/Job Template edit #205

Closed
3 of 7 tasks
yiyione opened this issue Jan 14, 2021 · 0 comments · Fixed by #272
Closed
3 of 7 tasks

Data/Job Template edit #205

yiyione opened this issue Jan 14, 2021 · 0 comments · Fixed by #272
Assignees
Labels
enhancement New feature or request

Comments

@yiyione
Copy link
Contributor

yiyione commented Jan 14, 2021

Introduction

Users can edit templates in the marketplace.

Issues / Motivations

Currently, users can't edit data or job templates directly in the marketplace, it will be a plus to add an edit function in the marketplace.

Proposals / Solutions

Add an edit button at the same place as the delete button. After the user clicks the button, a dialog will help the user change the editable fields of the template.

Work Plan

  • Add edit button
  • Add edit modal
  • Add cancel on dismiss

Test cases

  • Edit button should be disabled if the current user is not an admin neither author of the current template.
  • Click the edit button, the edit modal should show immediately.
  • If the user modified content of the edit modal but cancel by dismissing, the state change should be ignored.
  • If the user modified content of the edit modal and click submit button, the state change should be alert "update successfully", and the detail page will be changed immediately.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants