[Test only] BFloat16 test for SkipSimplifiedLayerNormalization #22941
+131
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiafatom
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
122
to
126
| skip_size); | ||
| } | ||
| else | ||
| { | ||
| LaunchSkipLayerNormKernel<CudaT, Simplified>( |
There was a problem hiding this comment.
Suggested change
| skip_size); | |
| } | |
| else | |
| { | |
| LaunchSkipLayerNormKernel<CudaT, Simplified>( | |
| skip_size); | |
| } else { | |
| LaunchSkipLayerNormKernel<CudaT, Simplified>( |
Comment on lines
18
to
22
| import tempfile | ||
| from typing import Dict | ||
| from enum import Enum | ||
|
|
There was a problem hiding this comment.
Suggested change
| import tempfile | |
| from typing import Dict | |
| from enum import Enum | |
| import tempfile | |
| from enum import Enum | |
| from typing import Dict | |
Comment on lines
24
to
27
| from onnx import AttributeProto, GraphProto, ModelProto, NodeProto, TensorProto, helper, numpy_helper | ||
| from onnx.shape_inference import infer_shapes, infer_shapes_path | ||
| from onnx.helper import float32_to_bfloat16 | ||
| from packaging import version |
There was a problem hiding this comment.
Suggested change
| from onnx import AttributeProto, GraphProto, ModelProto, NodeProto, TensorProto, helper, numpy_helper | |
| from onnx.shape_inference import infer_shapes, infer_shapes_path | |
| from onnx.helper import float32_to_bfloat16 | |
| from packaging import version | |
| from onnx import AttributeProto, GraphProto, ModelProto, NodeProto, TensorProto, helper, numpy_helper | |
| from onnx.helper import float32_to_bfloat16 | |
| from onnx.shape_inference import infer_shapes, infer_shapes_path | |
| from packaging import version |
Comment on lines
40
to
41
|
|
||
|
|
||
| def convert_np_to_float16(np_array, min_positive_val=5.96e-08, max_finite_val=65504.0): |
There was a problem hiding this comment.
Suggested change
| def convert_np_to_float16(np_array, min_positive_val=5.96e-08, max_finite_val=65504.0): | |
| def convert_np_to_float16(np_array, min_positive_val=5.96e-08, max_finite_val=65504.0): |
Comment on lines
110
to
+111
|
|
||
| def convert_tensor_float_to_bfloat16(tensor): |
There was a problem hiding this comment.
Suggested change
| def convert_tensor_float_to_bfloat16(tensor): | |
| def convert_tensor_float_to_bfloat16(tensor): |
Comment on lines
+189
to
+190
| class NodeValueType(Enum): | ||
| FP32 = 1 |
There was a problem hiding this comment.
Suggested change
| class NodeValueType(Enum): | |
| FP32 = 1 | |
| class NodeValueType(Enum): |
Comment on lines
194
to
195
| class InitializerTracker: | ||
| """Class for keeping track of initializer.""" |
There was a problem hiding this comment.
Suggested change
| class InitializerTracker: | |
| """Class for keeping track of initializer.""" | |
| class InitializerTracker: |
Comment on lines
211
to
212
| def convert_float_to_float16( | ||
| model, |
There was a problem hiding this comment.
Suggested change
| def convert_float_to_float16( | |
| model, | |
| def convert_float_to_float16( |
Comment on lines
470
to
471
|
|
||
| # Some operators have data type fixed as float for some input. Add a float16 to float cast for those inputs. | ||
| for node in mixed_float_type_node_list: |
There was a problem hiding this comment.
Suggested change
| # Some operators have data type fixed as float for some input. Add a float16 to float cast for those inputs. | |
| for node in mixed_float_type_node_list: | |
| # Some operators have data type fixed as float for some input. Add a float16 to float cast for those inputs. |
Comment on lines
18
to
23
| import tempfile | ||
| from typing import Dict | ||
| from enum import Enum | ||
| import ml_dtypes | ||
|
|
||
| import numpy as np |
There was a problem hiding this comment.
Suggested change
| import tempfile | |
| from typing import Dict | |
| from enum import Enum | |
| import ml_dtypes | |
| import numpy as np | |
| import tempfile | |
| from enum import Enum | |
| from typing import Dict | |
| import ml_dtypes | |
| import numpy as np |
jiafatom
force-pushed
the
skip_bf_16
branch
3 times, most recently
from
a198187 to
03bf839
Compare
Comment on lines
+122
to
+126
| skip_size); | ||
| } | ||
| else | ||
| { | ||
| LaunchSkipLayerNormKernel<CudaT, Simplified>( |
There was a problem hiding this comment.
Suggested change
| skip_size); | |
| } | |
| else | |
| { | |
| LaunchSkipLayerNormKernel<CudaT, Simplified>( | |
| skip_size); | |
| } else { | |
| LaunchSkipLayerNormKernel<CudaT, Simplified>( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context